Skip to content

Commit aaa3f8b

Browse files
committed
Add comprehensive BuildSettings types and TS fixes
Expand the BuildSettings interface with a large, organized set of Xcode build setting keys (SDK, Architectures, Deployment, Versioning, Product, Info.plist keys, Code Signing, Swift, Clang, GCC, Linking, warnings, and more), adding precise types, enums and documentation comments for each section. Also remove a couple of transient @ts-expect-error comments in XCBuildConfiguration when resolving settings so the code relies on the improved typings. These changes increase TypeScript coverage for Xcode settings and clean up previously suppressed type errors; review callers for potential typing adjustments if they depended on looser types.
1 parent 845ef05 commit aaa3f8b

File tree

2 files changed

+2009
-228
lines changed

2 files changed

+2009
-228
lines changed

src/api/XCBuildConfiguration.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,11 @@ export class XCBuildConfiguration extends AbstractObject<XCBuildConfigurationMod
149149
);
150150
}
151151

152-
// @ts-expect-error: A setting could refer to another setting that isn't of type string.
153152
return this.props.buildSettings[sub];
154153
};
155154

156155
const setting = this.props.buildSettings[buildSetting];
157156
if (typeof setting === "string") {
158-
// @ts-expect-error
159157
return resolveXcodeBuildSetting(setting, resolver);
160158
}
161159
if (Array.isArray(setting)) {

0 commit comments

Comments
 (0)