Fix XCLocalSwiftPackageReference type definition#35
Merged
Conversation
Remove incorrect `path` property and make `relativePath` required. The `path` property was based on CocoaPods/Xcodeproj which appears to have an inaccuracy - real pbxproj files only contain `relativePath`. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace `Record<string, any>` with a discriminated union type that captures all version requirement variants: - upToNextMajorVersion - upToNextMinorVersion - versionRange - exactVersion - branch - revision Also fix repositoryURL to be optional per the Swift implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
productName is always present in real pbxproj files. Also added documentation about the "plugin:" prefix for plugin dependencies. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add 24 tests covering: - XCLocalSwiftPackageReference: create, getDisplayName, is() - XCRemoteSwiftPackageReference: parsing, all 6 version requirement types - XCSwiftPackageProductDependency: parsing, create with local/remote refs - Round-trip serialization for all SPM types Also fix XCSwiftPackageProductDependency.getObjectProps() to properly declare `package` as a reference property, enabling automatic inflation/deflation of package references. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathproperty fromXCLocalSwiftPackageReferencerelativePathrequired (was optional)XCRemoteSwiftPackageReferenceContext
The original implementation was based on CocoaPods/Xcodeproj which defines both
pathandrelative_path. However, this appears to be inaccurate:relativePathrelativePathpathsays "repository url" which doesn't make sense for a local packageTest plan
🤖 Generated with Claude Code