Dispatch TaskStart event when execution loop dequeues task#6893
Draft
samstokes wants to merge 1 commit into
Draft
Dispatch TaskStart event when execution loop dequeues task#6893samstokes wants to merge 1 commit into
samstokes wants to merge 1 commit into
Conversation
TaskStart previously fired immediately after the per-plan enqueue channel accepted the message — i.e., when the worker accepted the task for execution, not when execution actually started. Move the dispatch into run_execution_loop so it fires when the message is dequeued and the task's inputs are about to be pushed into the running pipeline. The dispatch (event + subscribers) is carried on EnqueueInputMessage, so this works for every LocalSwordfishTask without touching individual task types. https://claude.ai/code/session_01QJ9jBxiSq9dPc1kdJHmr46
Rust Dependency DiffHead: ✅ OK: Within budget.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6893 +/- ##
==========================================
+ Coverage 75.34% 75.38% +0.04%
==========================================
Files 1135 1135
Lines 160433 160430 -3
==========================================
+ Hits 120881 120948 +67
+ Misses 39552 39482 -70
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Refactored the timing of
TaskStartevent dispatch to occur when the execution loop actually begins processing a task, rather than when the task is enqueued to the channel.Implementation Details
TaskStartDispatchstruct to carry both the event and subscribers togetheron_dequeuefield toEnqueueInputMessageto transport the dispatch information through the channelrun_execution_loop, immediately before the task's inputs are pushed into the running pipelineThis change provides more accurate timing for task execution monitoring and event-driven systems that depend on knowing when a task actually starts running.
Related Issues
https://claude.ai/code/session_01QJ9jBxiSq9dPc1kdJHmr46