Skip to content

Commit 33be988

Browse files
committed
Add missing parameter names
1 parent 79dd046 commit 33be988

5 files changed

Lines changed: 13 additions & 13 deletions

File tree

MiniInstaller/BackUp.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ static void ApplyVanillaPatchLibs(string patchLibsDir, string targetDir) {
6565

6666
Logger.LogLine("Applying patch vanilla libraries");
6767
ApplyVanillaPatchLibs(patchLibsDir, Globals.PathOrig);
68-
Directory.Delete(patchLibsDir, true);
68+
Directory.Delete(patchLibsDir, recursive: true);
6969
}
7070

7171
//Create symlinks

MiniInstaller/InGameUpdaterHelper.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public static void MoveFilesFromUpdate(string srcPath = null, string dstPath = n
1818

1919
// Check if we have a new runtime (=there is a piton-runtime folder both in the game and the update directory)
2020
if (Directory.Exists(Path.Combine(Globals.PathGame, "piton-runtime")) && Directory.Exists(Path.Combine(Globals.PathUpdate, "piton-runtime")))
21-
Directory.Delete(Path.Combine(Globals.PathGame, "piton-runtime"), true);
21+
Directory.Delete(Path.Combine(Globals.PathGame, "piton-runtime"), recursive: true);
2222
}
2323

2424
if (!Directory.Exists(dstPath))
@@ -29,7 +29,7 @@ public static void MoveFilesFromUpdate(string srcPath = null, string dstPath = n
2929

3030
if (File.Exists(entrySrc)) {
3131
Logger.LogLine($"Copying {entrySrc} +> {entryDst}");
32-
File.Copy(entrySrc, entryDst, true);
32+
File.Copy(entrySrc, entryDst, overwrite: true);
3333
} else
3434
MoveFilesFromUpdate(entrySrc, entryDst);
3535
}

MiniInstaller/LibAndDepHandling.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void CopyNativeLib(string src, string dst) {
8585
dst = Path.Combine(Path.GetDirectoryName(dst), mappedName);
8686
}
8787

88-
File.Copy(src, dst, true);
88+
File.Copy(src, dst, overwrite: true);
8989

9090
if (symlinkPath != null && symlinkPath != dst) {
9191
File.Delete(symlinkPath);
@@ -106,19 +106,19 @@ void CopyNativeLib(string src, string dst) {
106106

107107
// Copy our Steamworks.NET.dll
108108
string steamworksLibDst = Path.Combine(Globals.PathGame, "Steamworks.NET.dll");
109-
File.Copy(steamworksLibSrc, steamworksLibDst, true);
109+
File.Copy(steamworksLibSrc, steamworksLibDst, overwrite: true);
110110

111111
// Delete old libraries
112112
foreach (string libFile in Globals.WindowsNativeLibFileNames)
113113
File.Delete(Path.Combine(Globals.PathGame, libFile));
114114

115115
foreach (string libDir in new string[] { "lib", "lib64", "everest-lib64", "runtimes" }) {
116116
if (Directory.Exists(Path.Combine(Globals.PathGame, libDir)))
117-
Directory.Delete(Path.Combine(Globals.PathGame, libDir), true);
117+
Directory.Delete(Path.Combine(Globals.PathGame, libDir), recursive: true);
118118
}
119119

120120
if (Globals.PathOSXExecDir != null && Path.Exists(Path.Combine(Globals.PathOSXExecDir, "osx")))
121-
Directory.Delete(Path.Combine(Globals.PathOSXExecDir, "osx"), true);
121+
Directory.Delete(Path.Combine(Globals.PathOSXExecDir, "osx"), recursive: true);
122122

123123
// Finally make EverestSplash executable
124124
if (Globals.Platform is Globals.InstallPlatform.Linux or Globals.InstallPlatform.MacOS) {
@@ -137,7 +137,7 @@ void CopyNativeLib(string src, string dst) {
137137
}
138138

139139
public static void CopyControllerDB() {
140-
File.Copy(Path.Combine(Globals.PathEverestLib, "gamecontrollerdb.txt"), Path.Combine(Globals.PathGame, "gamecontrollerdb.txt"), true);
140+
File.Copy(Path.Combine(Globals.PathEverestLib, "gamecontrollerdb.txt"), Path.Combine(Globals.PathGame, "gamecontrollerdb.txt"), overwrite: true);
141141
Logger.LogLine("Copied gamecontrollerdb.txt");
142142
}
143143

MiniInstaller/MiscUtil.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,15 @@ public static bool IsSteamworksNet(string file) {
7272
}
7373
// This is not "pure" but I guess it also somewhat fits here
7474
public static void MoveExecutable(string srcPath, string dstPath) {
75-
File.Move(srcPath, dstPath, true);
75+
File.Move(srcPath, dstPath, overwrite: true);
7676

7777
if (Path.GetFullPath(Path.ChangeExtension(srcPath, null)) != Path.GetFullPath(Path.ChangeExtension(dstPath, null))) {
7878
if (File.Exists(Path.ChangeExtension(srcPath, ".pdb"))) {
79-
File.Move(Path.ChangeExtension(srcPath, ".pdb"), Path.ChangeExtension(dstPath, ".pdb"), true);
79+
File.Move(Path.ChangeExtension(srcPath, ".pdb"), Path.ChangeExtension(dstPath, ".pdb"), overwrite: true);
8080
}
8181

8282
if (File.Exists(Path.ChangeExtension(srcPath, ".mdb"))) {
83-
File.Move(Path.ChangeExtension(srcPath, ".mdb"), Path.ChangeExtension(dstPath, ".mdb"), true);
83+
File.Move(Path.ChangeExtension(srcPath, ".mdb"), Path.ChangeExtension(dstPath, ".mdb"), overwrite: true);
8484
}
8585
}
8686
}

MiniInstaller/Program.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public static int StandardMode(string[] args) {
8282

8383
if (Directory.Exists(Globals.PathMiniInstallerWorkspace)) {
8484
Logger.LogLine("MiniInstaller workspace already exists, cleaning before continuing.");
85-
Directory.Delete(Globals.PathMiniInstallerWorkspace, true);
85+
Directory.Delete(Globals.PathMiniInstallerWorkspace, recursive: true);
8686
}
8787

8888
Directory.CreateDirectory(Globals.PathMiniInstallerWorkspace);
@@ -115,7 +115,7 @@ public static int StandardMode(string[] args) {
115115
XmlDoc.CombineXMLDoc(Path.ChangeExtension(Globals.PathCelesteExe, ".Mod.mm.xml"), Path.ChangeExtension(Globals.PathCelesteExe, ".xml"));
116116

117117
// Everything went well, cleaning MiniInstaller workspace
118-
Directory.Delete(Globals.PathMiniInstallerWorkspace, true);
118+
Directory.Delete(Globals.PathMiniInstallerWorkspace, recursive: true);
119119

120120
// If we're updating, start the game. Otherwise, close the window.
121121
if (Globals.PathUpdate != null) {

0 commit comments

Comments
 (0)