Skip to content

Add TagsExt.FreezeFrameUpdate#1088

Open
aonkeeper4 wants to merge 13 commits into
EverestAPI:devfrom
aonkeeper4:freezeupdate-tag
Open

Add TagsExt.FreezeFrameUpdate#1088
aonkeeper4 wants to merge 13 commits into
EverestAPI:devfrom
aonkeeper4:freezeupdate-tag

Conversation

@aonkeeper4

@aonkeeper4 aonkeeper4 commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

This PR adds a new tag (TagsExt.FreezeFrameUpdate) to allow entities to update during freeze frames. I'm not sure whether the logic I have is all there needs to be, but so far it is all functional.

@aonkeeper4 aonkeeper4 changed the title Add TagsExt.FreezeUpdate Add TagsExt.FreezeFrameUpdate Feb 12, 2026
@maddie480-bot maddie480-bot added the 0: draft This PR is not ready for review yet (bot-managed) label Feb 12, 2026
# Conflicts:
#	Celeste.Mod.mm/Mod/Everest/Everest.Events.cs
@aonkeeper4 aonkeeper4 marked this pull request as ready for review March 20, 2026 15:27
@maddie480-bot maddie480-bot added 1: review needed This PR needs 2 approvals to be merged (bot-managed) and removed 0: draft This PR is not ready for review yet (bot-managed) labels Mar 20, 2026

@Wartori54 Wartori54 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice tag to add, just some polish missing.

Comment thread Celeste.Mod.mm/Patches/Monocle/Engine.cs
Comment thread Celeste.Mod.mm/Patches/Monocle/Scene.cs Outdated
Comment thread Celeste.Mod.mm/Patches/Level.cs
Comment thread Celeste.Mod.mm/Patches/Tags.cs Outdated
@maddie480-bot maddie480-bot added 2: changes requested This PR cannot be merged because changes were requested (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jun 24, 2026
@aonkeeper4

Copy link
Copy Markdown
Contributor Author

I've applied your changes, but I felt unsure about having the tag ignore Frozen and Transitioning, so I updated Level.FreezeFrameUpdate to more closely match Level.Update in that regard. This is reflected in the documentation changes.

@Wartori54

Copy link
Copy Markdown
Member

Yeah, that works too.

@maddie480-bot maddie480-bot added 1: review needed This PR needs 2 approvals to be merged (bot-managed) and removed 2: changes requested This PR cannot be merged because changes were requested (bot-managed) labels Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1: review needed This PR needs 2 approvals to be merged (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants