Restore float jank#1112
Open
maddie480 wants to merge 21 commits into
Open
Conversation
This reverts commit 0367a9a.
This reverts commit 8fab435
This reverts commit 1f13679.
This reverts commit eacd5ee.
This reverts commit cfc5c51.
This reverts commit fcdcb75.
This reverts commit bb25e6f.
This reverts commit fa7fc64
This reverts commit bf2cc09
This reverts commit 61041df
This reverts commit 3f6020c
This reverts commit 4e229e1
This reverts commit d8fe776
This reverts commit 4f0d395.
This reverts commit 3a5677a
This reverts commit 40b913f
This reverts commit f05c854.
maddie480-bot
added
the
1: review needed
Kalobi
reviewed
Apr 23, 2026
| ILCursor cursor = new ILCursor(context); | ||
|
|
||
| // Insert this code at the start of the method: | ||
| // if (!IsVisible()) |
Member
There was a problem hiding this comment.
Definitely some non-float-jank changes being caught in the crossfire here, this will need a manual pass of the actual patches that need to be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Violently ripping apart a dozen commits to try bringing back float jank ™️ (more seriously, preparing for the eventual switch of vanilla to Core, where the fixes should be removed if we want Everest to still match vanilla)