Fall back to mirrors on any exception when downloading mods#1117
Merged
SnipUndercover merged 2 commits intoMay 12, 2026
Conversation
SnipUndercover
requested changes
May 7, 2026
|
|
||
| break; // out of the loop | ||
| } catch (Exception e) when (e is WebException or TimeoutException or IOException) { | ||
| } catch (Exception e) when (e is WebException or TimeoutException or IOException or AuthenticationException) { |
Member
There was a problem hiding this comment.
The actual exception is a System.AggregateException that has an inner System.Net.Http.HttpRequestException, which then includes an System.Security.Authentication.AuthenticationException.
(which finally includes an System.ComponentModel.Win32Exception.)
Suggested change
| } catch (Exception e) when (e is WebException or TimeoutException or IOException or AuthenticationException) { | |
| } catch (Exception e) when (e is WebException or TimeoutException or IOException or AggregateException { InnerException: HttpRequestException }) { |
maddie480-bot
added
the
2: changes requested
maddie480
changed the title
SnipUndercover
approved these changes
May 8, 2026
maddie480-bot
added
1: review needed
microlith57
approved these changes
May 9, 2026
microlith57
left a comment
microlith57
left a comment
Member
There was a problem hiding this comment.
no don't fall back on the mirror, that's fragile, you might break it
Member
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
3: last call window
Member
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
4: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone in modding_help ran into this
Turns out they had a security thing blocking files.gamebanana.com, and Everest didn't fall back to a mirror, because this exception is not part of the caught exceptions (
TimeoutException,WebExceptionorIOException).This PR makes Everest fall back to a mirror on any exception like Olympus, most errors come from networking anyway.