Skip to content

Fall back to mirrors on any exception when downloading mods #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SnipUndercover merged 2 commits into from
May 12, 2026
Merged

Fall back to mirrors on any exception when downloading mods #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94749eb
Fall back to mirrors on AuthenticationExceptions
maddie480 May 7, 2026
6cb0d12
Catch all exceptions instead
maddie480 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Celeste.Mod.mm/Mod/UI/AutoModUpdater.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ private void autoUpdate(SortedDictionary<ModUpdateInfo, EverestModuleMetadata> u
ModUpdaterHelper.VerifyChecksum(update, zipPath);

break; // out of the loop
} catch (Exception e) when (e is WebException or TimeoutException or IOException) {
} catch (Exception e) {
downloadException = e;
Logger.Warn("AutoModUpdater", $"Download from {url} failed, trying another mirror");
Logger.LogDetailed(e);
Expand Down
2 changes: 1 addition & 1 deletion Celeste.Mod.mm/Mod/UI/OuiDependencyDownloader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ private void downloadDependency(ModUpdateInfo mod, EverestModuleMetadata install
LogLine(Dialog.Clean("DEPENDENCYDOWNLOADER_VERIFYING_CHECKSUM"));
ModUpdaterHelper.VerifyChecksum(mod, downloadDestination);
break; // out of the loop
} catch (Exception e) when (e is WebException or TimeoutException or IOException) {
} catch (Exception e) {
downloadException = e;
Logger.Warn("OuiDependencyDownloader", $"Download failed, trying another mirror");
Logger.LogDetailed(e);
Expand Down
2 changes: 1 addition & 1 deletion Celeste.Mod.mm/Mod/UI/OuiModUpdateList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ private void downloadMod(ModUpdateInfo update, TextMenu.Button button, string zi

ModUpdaterHelper.VerifyChecksum(update, zipPath);
break; // out of the loop
} catch (Exception e) when (e is WebException or TimeoutException) {
} catch (Exception e) {
downloadException = e;
Logger.Warn("OuiModUpdateList", $"Download from {url} failed, trying another mirror.");
Logger.LogDetailed(e);
Expand Down
Loading