Skip to content

Add debug editor option and improve layout handling of critical error handler#1121

Open
balt-dev wants to merge 6 commits into
EverestAPI:devfrom
balt-dev:feature-criterrorhandler-debugeditor
Open

Add debug editor option and improve layout handling of critical error handler#1121
balt-dev wants to merge 6 commits into
EverestAPI:devfrom
balt-dev:feature-criterrorhandler-debugeditor

Conversation

@balt-dev

@balt-dev balt-dev commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Adds an option to enter the debug level editor to the critical error handler, along with various UI touchups to accomodate having several entries.

2026-06-20.22-38-16.mp4

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Jun 1, 2026
microlith57
microlith57 approved these changes Jun 2, 2026
View reviewed changes

@microlith57 microlith57 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution!

Comment thread Celeste.Mod.mm/Mod/UI/CriticalErrorHandler.cs Outdated
@Kalobi

Kalobi commented Jun 18, 2026

Copy link
Copy Markdown
Member

I'm not a fan of having an option cut off at the bottom and having stuff move around for no reason while navigating the menu when there's plenty of space on screen to hold all of the options.
Also, this is not within the scope of this PR since you were just following the structure of the existing code, but I think it might be a good idea to make these texts localizable.

@SnipUndercover

SnipUndercover commented Jun 18, 2026

Copy link
Copy Markdown
Member

Also, this is not within the scope of this PR since you were just following the structure of the existing code, but I think it might be a good idea to make these texts localizable.

We have a drafted #991 that does that.

@balt-dev

balt-dev commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

I'm not a fan of having an option cut off at the bottom and having stuff move around for no reason while navigating the menu when there's plenty of space on screen to hold all of the options. Also, this is not within the scope of this PR since you were just following the structure of the existing code, but I think it might be a good idea to make these texts localizable.

The localization isn't my wheelhouse, and I didn't want to mess with the size of the player drawing in case someone else would take issue with that. It's also future-proofing for if more entries are added to the handler.

@balt-dev

balt-dev commented Jun 21, 2026

Copy link
Copy Markdown
Author

Went and redid a lot of the UI code as per discussion with Kalobi on Discord.

@balt-dev balt-dev changed the title Add debug editor option and scrolling to critical error handler Add debug editor option and improve layout handling of critical error handler Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@microlith57 microlith57 microlith57 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

1: review needed This PR needs 2 approvals to be merged (bot-managed)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@balt-dev @Kalobi @SnipUndercover @microlith57 @maddie480-bot