Update Steamworks.NET#956
Conversation
bd36aac to
3a7ac3a
Compare
|
Well, this is annoying. Because I added Steamworks.NET as a PackageReference, a reference assembly gets added to the output. This is not a huge problem for the everest build, as it gets overwritten with the correct assembly. What kinda sucks though is that this reference assembly will overwrite the original Steamworks.NET.dll, which means it will end up in the orig folder, breaking the unmodded game build. I looked for a way to massage I can see two ways to fix this:
For now, I think I'll try pursuing the first option. |
3a7ac3a to
4d83ef6
Compare
|
All fixed. Steamworks.NET.dll is now copied from lib-ext, so there's no more shenanigans going on with the orig directory. |
8dff6b3 to
59cab78
Compare
This allows mods to make use of the newer features provided by Steamworks.NET.
59cab78 to
e0d57e1
Compare
|
The everest-libs PR got merged, this is read for review. |
|
I'll rerun the pipeline since it errored out. |
|
/azp run |
|
@maddie480 It seems like the tas checks don't want to run? The action times out on waiting for the build to complete, even though it finished in 6 min. |
Wartori54
left a comment
There was a problem hiding this comment.
Changes are good, but not too happy since if Steamworks.NET.dll was platform and arch independent all of these would not be required at all.
Patching Steamworks.NET.dll to be like that is something not really in the scope of this PR though. (But it should be looked into in the future.)
it happens sometimes, Azure and GitHub Actions build "different merge commits", neither of which actually exist. GitHub builds ecc2f4d, Azure builds 11cb833, because ???? |
5a35029 to
e0d57e1
Compare
|
(pushed an empty commit then force pushed to remove it, now both GitHub Actions and Azure Pipelines are working on commit a63dd5d so it should be fine) |
|
The pull request was approved and entered the 3-day last-call window. |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
Well for some reason the checks are still showing that they're canceled. Either GitHub is high or something's wrong, but I don't think this'll affect TASes by any means. |
|
The checks on e0d57e1 pass if you go check the commit directly rather than the "Checks" tab, so I vote for "GitHub is high" |
This allows mods to make use of the newer features provided by Steamworks.NET. This is a requirement of my mod providing Steam Game Recording Integration.
Needs EverestAPI/Everest-libs#5This PR is merged!We're not updating to the very latest Steamworks.NET as it contains a breaking change that breaks Celeste (same as rlabrecque/Steamworks.NET#709). Fixing that would be relatively easy to do (just needs to nop out the call to
SteamUserStats.RequestCurrentStats()in celeste'sStats.MakeRequest), but given my use-case doesn't need the newer functionality offered by the very latest Steamworks, I opted for the path of least resistance.The largest part of the change is in the MiniInstaller. It does two things:
ConvertToNETCorecall. This is because otherwise, it would overwrite the previously copied Steamworks.NET with the version found in the orig folder, breaking everything.I verified it works on Windows 64-bit and macOS (both Steam builds).
Fixes #860