Skip to content

Commit 1958565

Browse files
authored
fix: remove no-op prose and codify authoring rule (#1000)
1 parent 65fed60 commit 1958565

6 files changed

Lines changed: 16 additions & 10 deletions

File tree

AGENTS.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,18 @@ Behavioral changes to a plugin skill or skill-local persona (anything under `ski
118118

119119
- **Mechanical changes do not have this restriction.** Skill scripts (e.g., `extract-metadata.py`), parser logic, conversion code, and anything `bun test` exercises always run the current source. The caching issue only affects LLM-driven skill prose behavior dispatched through the plugin loader.
120120

121+
## Writing Skill Instructions
122+
123+
Every line of skill prose must change agent behavior. Before keeping a line, apply the deletion test: if removing it would not change the output, it is a no-op — delete it. Agents already write detailed commit messages, try to be thorough, and aim for readable code by default, so generic exhortations to do those things ("be thorough", "be comprehensive", "write clean/readable code", "think carefully", "world-class", "high quality") are no-ops that only add tokens and noise.
124+
125+
A line earns its place when it does one of these:
126+
127+
- States a falsifiable constraint: a threshold, format, path, schema, or ordering.
128+
- Counters a known default tendency: a negative constraint ("do NOT add comments", "never push to main", "stop after X") or a guard against a shortcut the model would otherwise take.
129+
- Supplies domain knowledge the agent would not otherwise have.
130+
131+
An adjective is fine **only** when immediately operationalized by a concrete rule (e.g., "keep outputs concise — only enough detail to support the next decision"). The adjective alone is framing; the operationalization is the instruction. Do not append motivational rationale ("the quality of everything depends on this") to a directive that already stands on its own, and do not restate an instruction the same file already gives unless it is deliberate spaced repetition placed where drift occurs.
132+
121133
## Coding Conventions
122134

123135
- Prefer explicit mappings over implicit magic when converting between platforms.

skills/ce-compound/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Coordinate multiple subagents working in parallel to document a recently solved
1010

1111
## Purpose
1212

13-
Captures problem solutions while context is fresh, creating structured documentation in `docs/solutions/` with YAML frontmatter for searchability and future reference. Uses parallel subagents for maximum efficiency.
13+
Captures problem solutions while context is fresh, creating structured documentation in `docs/solutions/` with YAML frontmatter for searchability and future reference. Uses parallel subagents.
1414

1515
**Why "compound"?** Each documented solution compounds your team's knowledge. The first time you solve a problem takes research. Document it, and the next occurrence takes minutes. Knowledge compounds.
1616

skills/ce-dogfood-beta/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ Because tasks are session-scoped but the report doc is on disk, the report is th
7575

7676
### Phase 1: Analyze Changes
7777

78-
Pull the full diff against `main` and read it carefully — you cannot test what you don't understand.
78+
Pull the full diff against `main` and read it.
7979

8080
```bash
8181
git diff --name-only main...HEAD # what changed
@@ -88,7 +88,7 @@ Build a mental model of every change: new features, modified behavior, new route
8888

8989
### Phase 2: Map the Flows, Then Build the Matrix
9090

91-
The quality of the whole dogfood depends on this phase. Do not jump straight to a flat list of pages. First **understand the user flows the diff touches**, then derive the matrix from them. A matrix built without a flow model tests pages in isolation and misses the journey — the email that "sends" but lands in the wrong thread.
91+
Do not jump straight to a flat list of pages. First **understand the user flows the diff touches**, then derive the matrix from them. A matrix built without a flow model tests pages in isolation and misses the journey — the email that "sends" but lands in the wrong thread.
9292

9393
#### 2a. Map the user flows (required)
9494

skills/ce-simplify-code/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: "Simplify recently changed code for clarity, reuse, quality, and ef
44
argument-hint: "[blank to simplify current branch changes, or describe what to simplify]"
55
---
66

7-
You are an engineer that is an expert at simplifying code with a specific focus on enhancing code clarity, consistency, and maintainability while preserving exact functionality. Your expertise lies in applying project-specific best practices to simplify and improve code without altering its behavior. You prioritize readable, explicit code over overly compact solutions.
7+
Simplify code for clarity, consistency, and maintainability while preserving exact functionality. Prioritize readable, explicit code over overly compact solutions.
88

99
Review the changed code for reuse, quality, and efficiency. Fix any issues found. Then verify behavior is preserved by running the project's test suite.
1010

skills/ce-work-beta/SKILL.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -418,9 +418,6 @@ When `delegation_active` is true after argument parsing, read `references/codex-
418418

419419
### Quality is Built In
420420

421-
- Follow existing patterns
422-
- Write tests for new code
423-
- Run linting before pushing
424421
- Review when Tier 1 is available or Tier 2 criteria match (see `shipping-workflow.md`)
425422

426423
### Ship Complete Features

skills/ce-work/SKILL.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,9 +367,6 @@ Tier 1 harness-native review may still fix inline; Tier 2 always separates revie
367367

368368
### Quality is Built In
369369

370-
- Follow existing patterns
371-
- Write tests for new code
372-
- Run linting before pushing
373370
- Review when Tier 1 is available or Tier 2 criteria match (see `shipping-workflow.md`)
374371

375372
### Ship Complete Features

0 commit comments

Comments
 (0)