Skip to content

Перевод на net8#1562

Merged
EvilBeaver merged 3 commits into
developfrom
feature/net8
Aug 4, 2025
Merged

Перевод на net8#1562
EvilBeaver merged 3 commits into
developfrom
feature/net8

Conversation

@EvilBeaver

@EvilBeaver EvilBeaver commented Aug 4, 2025

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores

    • Updated build scripts and project configurations to use .NET 8.0 instead of .NET 6.0.
    • Increased the release candidate version suffix in the build pipeline from rc.8 to rc.9.
    • Improved framework version management in build scripts for consistency.
  • Bug Fixes

    • Restricted binary serialization functionality to .NET Framework 4.8 builds only, preventing its use on unsupported frameworks.

@coderabbitai

coderabbitai Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

This update standardizes the .NET target framework across build scripts and project files, moving from .NET 6.0 to .NET 8.0. It introduces a configurable MSBuild property for the framework version, updates related build and publish commands, adjusts conditional compilation for serialization, and increments the Jenkins pipeline version suffix.

Changes

Cohort / File(s) Change Summary
Build system framework unification
Build.csproj, src/oscommon.targets, src/TestApp/TestApp.csproj
Introduced ActiveFramework property set to net8.0 and updated all target framework references and publish commands to use it; changed default and project target frameworks from .NET 6.0 to .NET 8.0.
Jenkins pipeline versioning
Jenkinsfile
Updated VersionSuffix from rc.8 to rc.9 in the Jenkins environment variable.
Conditional serialization for .NET 4.8
src/OneScript.DebugProtocol/TcpServer/BinaryChannel.cs
Added conditional compilation for binary serialization: restricts BinaryFormatter usage to .NET Framework 4.8 builds only.

Sequence Diagram(s)

sequenceDiagram
    participant Jenkins
    participant MSBuild
    participant TestApp
    participant BinaryChannel

    Jenkins->>MSBuild: Set VersionSuffix to 'rc.9+${BUILD_NUMBER}'
    MSBuild->>TestApp: Build with TargetFramework=$(ActiveFramework) (net8.0)
    MSBuild->>BinaryChannel: Compile with NET48 conditional for serialization
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

A hop from six to eight, the frameworks align,
Jenkins counts rc.9, in orderly line.
Serialization fenced for legacy’s sake,
Build scripts unified—no more retake!
With every .csproj tuned just right,
The code hops forward, clean and bright.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 603046f and ddebb7a.

📒 Files selected for processing (5)
  • Build.csproj (3 hunks)
  • Jenkinsfile (1 hunks)
  • src/OneScript.DebugProtocol/TcpServer/BinaryChannel.cs (1 hunks)
  • src/TestApp/TestApp.csproj (1 hunks)
  • src/oscommon.targets (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/net8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@EvilBeaver EvilBeaver merged commit bd9b7e4 into develop Aug 4, 2025
1 of 4 checks passed
@EvilBeaver EvilBeaver deleted the feature/net8 branch August 4, 2025 08:57
@coderabbitai coderabbitai Bot mentioned this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant