Merge pull request #139 from sonarta/master

fix: handle empty parseResponse for nested script execution (issue #136)

Author: EvilFreelancer

src/Client.php

@@ -252,7 +252,7 @@ public function readRAW(array $options = [])
         }
 
         // Read answer from socket in loop, or until timeout reached
-        $startTime  = time();
+        $startTime = time();
         while (true) {
             // Exit from loop if timeout reached
             if (time() > $startTime + $this->config('socket_timeout')) {
@@ -374,7 +374,10 @@ private function rosario(array $raw): array
                 }
 
                 // Save as result
-                if(null != $this->parseResponse($item)) $result[] = $this->parseResponse($item)[0];
+                $parsed = $this->parseResponse($item);
+                if (!empty($parsed) && isset($parsed[0])) {
+                    $result[] = $parsed[0];
+                }
             }
 
         } else {

tests/ClientTest.php

@@ -43,13 +43,17 @@ public function setUp(): void
             'ssh_port' => (int) getenv('ROS_SSH_PORT'),
         ];
 
-        $this->client = new class($this->config) extends Client {
+        $this->client =
+
+            new class ($this->config) extends Client {
+
             // Convert protected method to public
             public function pregResponse(string $value, ?array &$matches): void
             {
                 parent::pregResponse($value, $matches);
             }
-        };
+
+            };
 
         $this->portModern = (int) getenv('ROS_PORT_MODERN');
         $this->portLegacy = (int) getenv('ROS_PORT_LEGACY');
@@ -353,4 +357,23 @@ public function test_export_asQuery(): void
         $result = $this->client->query('/export');
         self::assertNotEmpty($result);
     }
+
+    public function test_parseResponse_emptyArrayHandling(): void
+    {
+        // Simulate responses that could come from nested script execution
+        $emptyResponse = [];
+        $result        = $this->client->parseResponse($emptyResponse);
+        self::assertIsArray($result);
+        self::assertEmpty($result);
+
+        // Response with only control words (no data)
+        $doneOnlyResponse = ['!done'];
+        $result           = $this->client->parseResponse($doneOnlyResponse);
+        self::assertIsArray($result);
+
+        // Response with trap (error case)
+        $trapResponse = ['!trap', '=message=no such command'];
+        $result       = $this->client->parseResponse($trapResponse);
+        self::assertIsArray($result);
+    }
 }