Skip to content

fix: Prevent Duplicate Cron Jobs for Chatwoot Message Sync #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidsonGomes merged 4 commits into from
Sep 9, 2025
Merged

fix: Prevent Duplicate Cron Jobs for Chatwoot Message Sync #1906

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70a2c18
Merge branch 'release/2.3.2'
DavidsonGomes Sep 2, 2025
c2085b5
Merge branch 'release/2.3.2'
DavidsonGomes Sep 2, 2025
43cc6d3
check cronId before executing syncChatwootLostMessages
andres99x Sep 3, 2025
613d486
stop tasks with missmatch cronId
andres99x Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4357,7 +4357,18 @@ export class BaileysStartupService extends ChannelStartupService {
const prepare = (message: any) => this.prepareMessage(message);
this.chatwootService.syncLostMessages({ instanceName: this.instance.name }, chatwootConfig, prepare);

// Generate ID for this cron task and store in cache
const cronId = cuid();
const cronKey = `chatwoot:syncLostMessages`;
await this.chatwootService.getCache()?.hSet(cronKey, this.instance.name, cronId);

const task = cron.schedule('0,30 * * * *', async () => {
// Check ID before executing (only if cache is available)
const cache = this.chatwootService.getCache();
if (cache) {
const storedId = await cache.hGet(cronKey, this.instance.name);
if (storedId && storedId !== cronId) return;
}
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Returning early in the cron task may mask underlying issues.

Adding a log statement when the task is skipped due to ID mismatch will help with future debugging and monitoring.

Suggested change
if (cache) {
const storedId = await cache.hGet(cronKey, this.instance.name);
if (storedId && storedId !== cronId) return;
}
if (cache) {
const storedId = await cache.hGet(cronKey, this.instance.name);
if (storedId && storedId !== cronId) {
this.logger?.info?.(
`[ChatwootSyncLostMessages] Skipping cron task for instance "${this.instance.name}" due to ID mismatch (storedId: ${storedId}, cronId: ${cronId})`
);
return;
}
}

this.chatwootService.syncLostMessages({ instanceName: this.instance.name }, chatwootConfig, prepare);
});
task.start();
Expand Down