fix: avoid manager flicker during instance polling#14
Open
TBDevMaster wants to merge 2 commits intoEvolutionAPI:mainfrom
Open
fix: avoid manager flicker during instance polling#14TBDevMaster wants to merge 2 commits intoEvolutionAPI:mainfrom
TBDevMaster wants to merge 2 commits intoEvolutionAPI:mainfrom
Conversation
There was a problem hiding this comment.
Sorry @TBDevMaster, your pull request is larger than the review limit of 150000 diff characters
Author
|
Sourcery skipped this PR because the repository stores the manager as a built/minified bundle, so a very small functional change in The actual logic change is small: Before:
After:
In other words, the functional change is: // before
t({ isLoading: true, error: null })
// after
t((state) => ({ isLoading: !state.hasLoaded, error: null }))and successful/failed fetches now also set:
hasLoaded: true
This fixes the flicker reported in #11 while keeping the initial loading state intact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the manager UI flicker reported when the instances page refreshes every 5 seconds.
The issue happens because the instances polling path sets
isLoading: trueon everyfetchInstances()call. The manager page uses that flag to swap the whole list for skeleton cards, so each polling cycle causes a visible full-page flash.What changed
hasLoadedflag to the instances storeWhy this fixes the flicker
Before:
isLoading = trueisLoading = trueagainAfter:
isLoading = truehasLoaded = trueNotes
This repository currently includes the built manager bundle, so the change is applied in
manager/dist/assets/index-LD46dRLh.js.Closes #11.