fix: guard choices[0] and message=None before content access (41 sites, 32 files)#1332
Open
qizwiz wants to merge 1 commit into
Open
fix: guard choices[0] and message=None before content access (41 sites, 32 files)#1332qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
OpenAI-compatible APIs can return empty choices on error or content filtering; Gemini returns choices[0].message=None on PROHIBITED_CONTENT (HTTP 200). Both cause unhandled exceptions at runtime. Adds `if not response.choices or response.choices[0].message is None:` before every bare `choices[0].message.content` access across 32 files.
kcz358
reviewed
May 20, 2026
Collaborator
There was a problem hiding this comment.
Is this file got wrongly modified? The git diff looks not as expected as well as the other utils in mme_sci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAI-compatible APIs can return empty
choiceson error or rate-limiting, causingIndexErroratchoices[0]. Gemini additionally returnschoices[0].message = NoneonPROHIBITED_CONTENTsafety filtering (HTTP 200 — no exception raised), causingAttributeErrorat.content.This PR adds the comprehensive guard:
before every bare
choices[0].message.contentaccess across 32 files, 41 sites.Impact
Affected subsystems:
lmms_eval/llm_judge/providers/— OpenAI and Azure OpenAI judge providerslmms_eval/models/— core model implementations (chat/openai, simple/openai, srt_api, gpt4v)lmms_eval/tasks/— 25+ task evaluation utilities across aime, babyvision, gpqa, live_bench, mathverse, mix_evals, mme_sci, openai_math, phyx, tomato, videoevalpro, videomme, and unig2u taskstest/models/test_litellm.pyVerification
The Gemini
choices[0].message = Nonecrash is a documented production behavior onPROHIBITED_CONTENTsafety filtering. Static analysis via pact (Z3 Fixedpoint datalog,llm_response_unguardedrule) found all 41 sites; post-fix scan returns 0 violations.