refactor(tasks): migrate 10 benchmarks from llm_judge to the verifiers pipeline#1388
Open
Luodian wants to merge 3 commits into
Open
refactor(tasks): migrate 10 benchmarks from llm_judge to the verifiers pipeline#1388Luodian wants to merge 3 commits into
Luodian wants to merge 3 commits into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates 10 benchmarks from the legacy
lmms_eval.llm_judgeserver API to the newlmms_eval.verifierspipeline introduced by the stackedfeat/verifiers-modulePR.Each task's LLM-judge call is replaced by a lazily-constructed
VerificationPipeline(threaded double-checked singleton) built from the package'sOpenAIVerifierprovider, with per-task extractors/prompts/response-parsers preserved. Scoring behavior is preserved with three deliberate exceptions, listed under Behavior notes below.Tasks migrated
openaiclient + GPT4oJudgeuse_lmms_judge; exact-match fallback on judge failureuse_lmms_judge; direct-comparison fallback on judge failureAll migrations use only the
openaiprovider (present in the verifiers package).Behavior notes (deliberate changes)
custom_promptwith no question/answer/prediction substituted —build_binary_promptreturns such prompts unchanged and the provider ignores the request fields, so the GPT rescue never actually graded anything (a latent no-op). The migrated prompt substitutes the real fields, so open-ended mmvu scores will move. This is a bug fix, not drift.StripReasoningExtractorbefore judging — reasoning blocks no longer reach the judge.Validation
py_compilepasses on all 10 files.!function utils.*references resolve.ruff: 6 findings, all pre-existing (identical to base, line-shifted only); migration introduces zero new lint.Notes
fix/task-utils-improvements; a trivial re-merge may be needed depending on merge order.llm_judgeimport: a second, un-migrated judge path still uses it.Review pass (2026-07-06)
judge_failedmetadata, compositeconfidentcontract) into this branch.judge_failed(the pipeline swallows judge exceptions, so the oldexcept-based fallbacks had become unreachable)._create_judge_prompthelper.