fix(packaging): include extensionless task template files in pip wheel#1390
Open
mandanajignesh-byte wants to merge 1 commit into
Conversation
Task template files like _default_template_rec_yaml are referenced via 'include:' directives in .yaml configs but have no file extension, so they were excluded from the pip wheel by the existing glob patterns. This caused FileNotFoundError for any task using extensionless templates when installed via pip (not git clone). Affected tasks include screenspot, gpqa, mmmu, mmbench, videomme and 170+ others (181 files total). Fix: add 'tasks/**/*' glob to package-data to include all files under the tasks directory regardless of extension. Fixes EvolvingLMMs-Lab#1350
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task template files like _default_template_rec_yaml are referenced via 'include:' directives in .yaml configs but have no file extension, so they were excluded from the pip wheel by the existing glob patterns.
This caused FileNotFoundError for any task using extensionless templates when installed via pip (not git clone). Affected tasks include screenspot, gpqa, mmmu, mmbench, videomme and 170+ others (181 files total).
Fix: add 'tasks/**/*' glob to package-data to include all files under the tasks directory regardless of extension.
Fixes #1350
Summary
In scope
Out of scope
Validation
Risk / Compatibility
Type of Change