Skip to content

fix(website): improve tool result table layouts#1159

Closed
PrzemyslawKlys wants to merge 1 commit into
masterfrom
codex/fix-tools-table-layout
Closed

fix(website): improve tool result table layouts#1159
PrzemyslawKlys wants to merge 1 commit into
masterfrom
codex/fix-tools-table-layout

Conversation

@PrzemyslawKlys
Copy link
Copy Markdown
Member

Summary

  • add shared wrapping and overflow handling for tool result tables
  • improve DNS propagation answer-set rendering for long IPv4 and IPv6 values
  • apply the shared data-table styling to both DNS propagation and DANE views

Validation

  • dotnet build DomainDetective.Website/DomainDetective.Website.csproj -c Release

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@claude
Copy link
Copy Markdown

claude Bot commented Apr 3, 2026

PR Review: fix(website) improve tool result table layouts. Overall well-scoped. Key concerns: (1) DnsPropagationAnswerSetInfo.Label appears to be dead code after this PR since the template now iterates GetAnswerSetEntries directly instead of rendering answerSet.Label. (2) table-layout:fixed and width:32% on first-child of .result-table affects ALL ResultTable usages globally, not just DNS/DANE - worth auditing. (3) .tool-data-table-dane has no width rule for column 6, only columns 1-5 and 7. Positives: the FormatAnswerSet/FormatRecords to entry-list refactor is clean and improves readability for IPv6/multi-record sets.

@PrzemyslawKlys
Copy link
Copy Markdown
Member Author

Superseded by #1166. Closing this to keep the website work on a single active PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant