Skip to content

fix(website): improve tool result table layouts #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PrzemyslawKlys wants to merge 1 commit into from
Closed

fix(website): improve tool result table layouts #1159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions DomainDetective.Toolbox/Components/Shared/ResultTable.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
<table class="result-table">
<thead>
<tr>
@foreach (var col in Columns) {
<th>@col</th>
}
</tr>
</thead>
<tbody>
@ChildContent
</tbody>
</table>
<div class="result-table-wrap">
<table class="result-table">
<thead>
<tr>
@foreach (var col in Columns) {
<th>@col</th>
}
</tr>
</thead>
<tbody>
@ChildContent
</tbody>
</table>
</div>

@code {
[Parameter] public string[] Columns { get; set; } = Array.Empty<string>();
Expand Down
41 changes: 31 additions & 10 deletions DomainDetective.Toolbox/Components/Tools/Dns/DnsPropagationTool.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,16 @@
</div>

<ResultTable Columns="@(new[] { "Property", "Value" })">
<tr><td>Majority answer set</td><td>@FormatAnswerSet(item.MajorityAnswerSet)</td></tr>
<tr>
<td>Majority answer set</td>
<td>
<div class="tool-value-stack">
@foreach (var value in GetAnswerSetEntries(item.MajorityAnswerSet)) {
<code>@value</code>
}
</div>
</td>
</tr>
<tr><td>Average response time</td><td>@FormatDuration(item.AvgDuration)</td></tr>
<tr><td>Fastest response</td><td>@FormatDuration(item.MinDuration)</td></tr>
<tr><td>Slowest response</td><td>@FormatDuration(item.MaxDuration)</td></tr>
Expand All @@ -89,7 +98,13 @@
<ResultTable Columns="@(new[] { "Answer set", "Resolvers", "Status" })">
@foreach (var answerSet in answerSets) {
<tr>
<td>@answerSet.Label</td>
<td>
<div class="tool-value-stack">
@foreach (var value in GetAnswerSetEntries(answerSet.Key)) {
<code>@value</code>
}
</div>
</td>
<td>@answerSet.Count</td>
<td>@(answerSet.IsMajority ? "Majority" : "Observed")</td>
</tr>
Expand All @@ -98,7 +113,7 @@
}

<div class="tool-data-table-wrap">
<table class="tool-data-table">
<table class="tool-data-table tool-data-table-dns">
<thead>
<tr>
<th>Resolver</th>
Expand All @@ -120,7 +135,13 @@
@(result.Success ? "Seen" : "Unavailable")
</span>
</td>
<td>@FormatRecords(result.Records)</td>
<td>
<div class="tool-value-stack">
@foreach (var value in GetRecordEntries(result.Records)) {
<code>@value</code>
}
</div>
</td>
<td>@FormatDuration(result.Duration)</td>
</tr>
}
Expand Down Expand Up @@ -214,7 +235,7 @@
.GroupBy(static result => NormalizeAnswerSet(result.Records), StringComparer.OrdinalIgnoreCase)
.Select(group => new DnsPropagationAnswerSetInfo {
Key = group.Key,
Label = FormatAnswerSet(group.Key),
Label = string.Join(" | ", GetAnswerSetEntries(group.Key)),
Count = group.Count(),
IsMajority = string.Equals(group.Key, item.MajorityAnswerSet ?? string.Empty, StringComparison.OrdinalIgnoreCase)
})
Expand Down Expand Up @@ -246,9 +267,9 @@
return values.Length > 0 ? string.Join(", ", values) : "(no answer)";
}

private static string FormatAnswerSet(string? value) {
private static IReadOnlyList<string> GetAnswerSetEntries(string? value) {
if (string.IsNullOrWhiteSpace(value) || string.Equals(value, "(no answer)", StringComparison.OrdinalIgnoreCase)) {
return "No majority answer set";
return new[] { "No majority answer set" };
}

var entries = value
Expand All @@ -257,7 +278,7 @@
.Where(static item => item.Length > 0)
.ToArray();

return entries.Length > 0 ? string.Join(", ", entries) : "No majority answer set";
return entries.Length > 0 ? entries : new[] { "No majority answer set" };
}

private static string FormatBool(bool value) {
Expand Down Expand Up @@ -309,9 +330,9 @@
return !string.IsNullOrWhiteSpace(result.Asn) ? result.Asn : "Unknown";
}

private static string FormatRecords(IEnumerable<string> records) {
private static IReadOnlyList<string> GetRecordEntries(IEnumerable<string> records) {
var values = records?.Where(static value => !string.IsNullOrWhiteSpace(value)).ToArray() ?? Array.Empty<string>();
return values.Length > 0 ? string.Join(", ", values) : "No answer";
return values.Length > 0 ? values : new[] { "No answer" };
}

private static string FormatResolver(DnsPropagationResultInfo result) {
Expand Down
2 changes: 1 addition & 1 deletion DomainDetective.Toolbox/Components/Tools/TlsCert/DaneTool.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
@if (records.Count > 0) {
<ResultCard Title="TLSA records" Status="ResultCard.ResultStatus.Info">
<div class="tool-data-table-wrap">
<table class="tool-data-table">
<table class="tool-data-table tool-data-table-dane">
<thead>
<tr>
<th>Name</th>
Expand Down
163 changes: 163 additions & 0 deletions DomainDetective.Website/wwwroot/css/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,19 +1224,36 @@ a:hover { color: var(--dd-accent-light); }

/* ── Result Tables ──────────────────────────────────────────────── */

.result-table-wrap,
.tool-data-table-wrap {
width: 100%;
overflow-x: auto;
-webkit-overflow-scrolling: touch;
}

.result-table {
width: 100%;
min-width: 0;
border-collapse: collapse;
table-layout: fixed;
position: relative;
}
.result-table th,
.result-table td {
padding: 0.625rem 0.75rem;
text-align: left;
vertical-align: top;
border-bottom: 1px solid var(--dd-border);
font-size: 0.9rem;
white-space: normal;
word-break: break-word;
overflow-wrap: anywhere;
transition: background 0.15s ease;
}
.result-table th:first-child,
.result-table td:first-child {
width: 32%;
}
.result-table th {
color: var(--dd-accent);
font-weight: 600;
Expand Down Expand Up @@ -1271,6 +1288,146 @@ a:hover { color: var(--dd-accent-light); }
background: rgba(15, 143, 176, 0.055);
}

.tool-data-table {
width: 100%;
border-collapse: collapse;
table-layout: fixed;
}

.tool-data-table th,
.tool-data-table td {
padding: 0.75rem 1rem;
text-align: left;
vertical-align: top;
border-bottom: 1px solid var(--dd-border);
white-space: normal;
word-break: break-word;
overflow-wrap: anywhere;
}

.tool-data-table th {
color: var(--dd-accent);
font-size: 0.8rem;
font-weight: 600;
text-transform: uppercase;
letter-spacing: 0.06em;
background: linear-gradient(135deg, rgba(0, 217, 255, 0.08), rgba(139, 92, 246, 0.05));
border-bottom: 1px solid rgba(0, 217, 255, 0.15);
}

.tool-data-table td {
color: var(--dd-ink);
font-size: 0.95rem;
}

.tool-value-stack {
display: grid;
gap: 0.35rem;
}

.tool-value-stack code {
display: block;
width: fit-content;
max-width: 100%;
padding: 0.2rem 0.45rem;
border-radius: 0.5rem;
background: rgba(15, 23, 42, 0.45);
color: var(--dd-ink-strong);
font-family: var(--dd-font-mono);
font-size: 0.85rem;
white-space: normal;
word-break: break-word;
overflow-wrap: anywhere;
}

.tool-data-table tbody tr:nth-child(even) td {
background: linear-gradient(90deg, rgba(13, 21, 48, 0.3), rgba(13, 21, 48, 0.15));
}

.tool-data-table tbody tr:hover td {
background: rgba(0, 217, 255, 0.05);
}

.tool-data-table tr:last-child td {
border-bottom: none;
}

.tool-data-table-dns {
min-width: 56rem;
}

.tool-data-table-dns th:nth-child(1),
.tool-data-table-dns td:nth-child(1) {
width: 20%;
}

.tool-data-table-dns th:nth-child(2),
.tool-data-table-dns td:nth-child(2) {
width: 14%;
}

.tool-data-table-dns th:nth-child(3),
.tool-data-table-dns td:nth-child(3) {
width: 12%;
}

.tool-data-table-dns th:nth-child(4),
.tool-data-table-dns td:nth-child(4) {
width: 10%;
}

.tool-data-table-dns th:nth-child(5),
.tool-data-table-dns td:nth-child(5) {
width: 34%;
}

.tool-data-table-dns th:nth-child(6),
.tool-data-table-dns td:nth-child(6) {
width: 10%;
}

.tool-data-table-dane {
min-width: 60rem;
}

.tool-data-table-dane th:nth-child(1),
.tool-data-table-dane td:nth-child(1) {
width: 18rem;
}

.tool-data-table-dane th:nth-child(2),
.tool-data-table-dane td:nth-child(2),
.tool-data-table-dane th:nth-child(3),
.tool-data-table-dane td:nth-child(3),
.tool-data-table-dane th:nth-child(4),
.tool-data-table-dane td:nth-child(4),
.tool-data-table-dane th:nth-child(5),
.tool-data-table-dane td:nth-child(5) {
width: 6rem;
}

.tool-data-table-dane th:nth-child(7),
.tool-data-table-dane td:nth-child(7) {
width: 8rem;
}

[data-theme="light"] .tool-data-table th {
background: linear-gradient(135deg, rgba(15, 143, 176, 0.1), rgba(59, 130, 246, 0.08));
border-bottom-color: rgba(15, 143, 176, 0.16);
}

[data-theme="light"] .tool-data-table tbody tr:nth-child(even) td {
background: linear-gradient(90deg, rgba(15, 23, 42, 0.025), rgba(59, 130, 246, 0.03));
}

[data-theme="light"] .tool-data-table tbody tr:hover td {
background: rgba(15, 143, 176, 0.055);
}

[data-theme="light"] .tool-value-stack code {
background: rgba(226, 232, 240, 0.65);
}

.result-record {
background: var(--dd-code-bg);
border: 1px solid var(--dd-border);
Expand Down Expand Up @@ -2560,6 +2717,12 @@ a:hover { color: var(--dd-accent-light); }
}
.tool-breadcrumb { font-size: 0.8rem; padding: 0.375rem 0.5rem; }
.result-card { padding: 1rem; }
.result-table th,
.result-table td,
.tool-data-table th,
.tool-data-table td {
padding: 0.625rem 0.75rem;
}
.category-card:hover { transform: translateY(-2px); }
}

Expand Down
Loading