Skip to content

Add onInit function to code examples for AngularJS 1.8 compatibility. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rschwab wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add onInit function to code examples for AngularJS 1.8 compatibility. #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions VIEW_CODE/js/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,23 +138,23 @@ for the `prmSearchBarAfter` directive
```
controller: 'MyInstitutionComponentController',
```
- Define a controller with 2 getter methods to return the query and selected scope
- Define a controller with 2 getter methods to return the query and selected scope. In order to access the parentCtrl binding, the controller must implement the ngOnInit life cycle hook.
```
app.controller('MyInstitutionComponentController', [function () {
var vm = this;

this.$onInit = function () {

vm.getSelectdScope = getSelectdScope;
vm.getQuery = getQuery;
var vm = this;

vm.getSelectedScope = function() {
return vm.parentCtrl.scopeField;
}

function getSelectdScope() {
return vm.parentCtrl.scopeField;
vm.getQuery = function() {
return vm.parentCtrl.mainSearchField;
}
}

function getQuery() {
return vm.parentCtrl.mainSearchField;
}
}]);

```
Expand All @@ -171,7 +171,7 @@ template: `<div layout="row" layout-align="center center">
This is a demo presenting the ability to display query
information below the search box</span>
<span class="md-subhead">Query: {{$ctrl.getQuery()}}</span>
<span class="md-subhead">Scope: {{$ctrl.getSelectdScope()}}</span>
<span class="md-subhead">Scope: {{$ctrl.getSelectedScope()}}</span>
</md-card-title-text>
<md-card-title-media>
<div class="md-media-sm card-media"></div>
Expand Down Expand Up @@ -217,14 +217,14 @@ template: `<div layout="row" layout-align="center center">
- Define a controller that populates the doi and loads the Altmetrics js file
```
app.controller('MyInstitutionComponentController', ['angularLoad', function (angularLoad) {
var vm = this;
vm.doi = vm.parentCtrl.item.pnx.addata.doi[0] || '';
this.$onInit = function () {
var vm = this;
vm.doi = vm.parentCtrl.item.pnx.addata.doi[0] || '';

vm.$onInit = function () {
angularLoad.loadScript('https://d1bxh8uas1mnw7.cloudfront.net/assets/embed.js?' + Date.now()).then(function () {

});
};
}
}]);
```
- Edit the `prmFullViewAfter` directive template to reference the `myInstitutionComponent`
Expand Down