Partially Revert "fix: Scale fix (#571)"

This reverts commit b896a73.

Because of NW making crash on Player

Author: louis1706

EXILED/Exiled.API/Features/Player.cs

@@ -699,7 +699,7 @@ public ScpSpawnPreferences.SpawnPreferences ScpPreferences
         public Vector3 Scale
         {
             get => ReferenceHub.transform.localScale;
-            set => SetScale(value);
+            set => SetScale(value, List);
         }
 
         /// <summary>
@@ -2065,25 +2065,27 @@ public void Disconnect(string reason = null) =>
         /// </summary>
         public void ResetStamina() => Stamina = StaminaStat.MaxValue;
 
-        /// <summary>
-        /// Sets the scale of a player on the server side.
-        /// </summary>
-        /// <param name="scale">The scale to set.</param>
-        public void SetScale(Vector3 scale)
-        {
-            ReferenceHub.transform.localScale = scale;
-            new SyncedScaleMessages.ScaleMessage(scale, ReferenceHub).SendToAuthenticated();
-        }
-
         /// <summary>
         /// Sets the scale of a player on the server side.
         /// </summary>
         /// <param name="scale">The scale to set.</param>
         /// <param name="viewers">Who should see the updated scale.</param>
         public void SetScale(Vector3 scale, IEnumerable<Player> viewers)
         {
-            ReferenceHub.transform.localScale = scale;
-            new SyncedScaleMessages.ScaleMessage(scale, ReferenceHub).SendToHubsConditionally(x => x != null && viewers.Contains(Get(x)));
+            if (scale == Scale)
+                return;
+
+            try
+            {
+                ReferenceHub.transform.localScale = scale;
+
+                foreach (Player target in viewers)
+                    Server.SendSpawnMessage?.Invoke(null, new object[] { NetworkIdentity, target.Connection });
+            }
+            catch (Exception exception)
+            {
+                Log.Error($"{nameof(SetScale)} error: {exception}");
+            }
         }
 
         /// <summary>
@@ -2093,9 +2095,21 @@ public void SetScale(Vector3 scale, IEnumerable<Player> viewers)
         /// <param name="viewers">Who should see the fake scale.</param>
         public void SetFakeScale(Vector3 fakeScale, IEnumerable<Player> viewers)
         {
-            SyncedScaleMessages.ScaleMessage scaleMessage = new(fakeScale, ReferenceHub);
-            foreach (Player player in viewers)
-                player.Connection.Send(scaleMessage, 0);
+            Vector3 currentScale = Scale;
+
+            try
+            {
+                ReferenceHub.transform.localScale = fakeScale;
+
+                foreach (Player target in viewers)
+                    Server.SendSpawnMessage.Invoke(null, new object[] { NetworkIdentity, target.Connection });
+
+                ReferenceHub.transform.localScale = currentScale;
+            }
+            catch (Exception ex)
+            {
+                Log.Error($"{nameof(SetFakeScale)}: {ex}");
+            }
         }
 
         /// <summary>

EXILED/Exiled.CustomRoles/API/Features/CustomRole.cs

@@ -564,7 +564,7 @@ public virtual void AddRole(Player player)
             Log.Debug($"{Name}: Setting health values.");
             player.Health = MaxHealth;
             player.MaxHealth = MaxHealth;
-            Timing.CallDelayed(0.1f, () => player.Scale = Scale); // To fix : remove the delay in 14.1.2 once the crash issue is resolved
+            player.Scale = Scale;
             if (Gravity.HasValue && player.Role is FpcRole fpcRole)
                 fpcRole.Gravity = Gravity.Value;
             Vector3 position = GetSpawnPosition();
@@ -627,6 +627,7 @@ public virtual void RemoveRole(Player player)
             TrackedPlayers.Remove(player);
             player.CustomInfo = string.Empty;
             player.InfoArea |= PlayerInfoArea.Role | PlayerInfoArea.Nickname;
+            player.Scale = Vector3.one;
             if (CustomAbilities is not null)
             {
                 foreach (CustomAbility ability in CustomAbilities)