Requested Changed by Yamato when reviewing the Changelog

Author: louis1706

EXILED/Exiled.API/Extensions/MirrorExtensions.cs

@@ -171,25 +171,24 @@ public static ReadOnlyDictionary<string, string> RpcFullNames
         /// <param name="itemType">Weapon' sound to play.</param>
         /// <param name="volume">Sound's volume to set.</param>
         /// <param name="audioClipId">GunAudioMessage's audioClipId to set (default = 0).</param>
-        [Obsolete("This method is not working. Use PlayGunSound(Player, Vector3, ItemType, float, int, bool) overload instead.")]
+        [Obsolete("This method is not working. Use PlayGunSound(Player, Vector3, FirearmType, float, int, bool) overload instead.")]
         public static void PlayGunSound(this Player player, Vector3 position, ItemType itemType, byte volume, byte audioClipId = 0)
-        {
-        }
+            => PlayGunSound(player, position, itemType.GetFirearmType(), volume, audioClipId);
 
         /// <summary>
         /// Plays a gun sound that only the <paramref name="player"/> can hear.
         /// </summary>
         /// <param name="player">Target to play.</param>
         /// <param name="position">Position to play on.</param>
-        /// <param name="itemType">Weapon's sound to play.</param>
+        /// <param name="firearmType">Weapon's sound to play.</param>
         /// <param name="pitch">Speed of sound.</param>
         /// <param name="clipIndex">Index of clip.</param>
-        public static void PlayGunSound(this Player player, Vector3 position, FirearmType itemType, float pitch = 1, int clipIndex = 0)
+        public static void PlayGunSound(this Player player, Vector3 position, FirearmType firearmType, float pitch = 1, int clipIndex = 0)
         {
-            if (itemType is FirearmType.ParticleDisruptor or FirearmType.None)
+            if (firearmType is FirearmType.ParticleDisruptor or FirearmType.None)
                 return;
 
-            Features.Items.Firearm firearm = Features.Items.Firearm.ItemTypeToFirearmInstance[itemType];
+            Features.Items.Firearm firearm = Features.Items.Firearm.ItemTypeToFirearmInstance[firearmType];
 
             if (firearm == null)
                 return;

EXILED/Exiled.API/Features/Core/UserSettings/SettingBase.cs

@@ -262,11 +262,11 @@ public static IEnumerable<SettingBase> Register(IEnumerable<SettingBase> setting
         /// <summary>
         /// Registers all settings from the specified collection to player.
         /// </summary>
-        /// <param name="settings">A collection of settings to register.</param>
         /// <param name="player">A player that will receive settings.</param>
+        /// <param name="settings">A collection of settings to register.</param>
         /// <returns>A <see cref="IEnumerable{T}"/> of <see cref="SettingBase"/> instances that were successfully registered.</returns>
         /// <remarks>This method is used to sync new settings with players.</remarks>
-        public static IEnumerable<SettingBase> Register(IEnumerable<SettingBase> settings, Player player)
+        public static IEnumerable<SettingBase> Register(Player player, IEnumerable<SettingBase> settings)
         {
             IEnumerable<IGrouping<HeaderSetting, SettingBase>> grouped = settings.Where(s => s != null).GroupBy(s => s.Header);
 
@@ -319,7 +319,7 @@ public static IEnumerable<SettingBase> Unregister(Func<Player, bool> predicate =
         /// <param name="player">Determines which player will receive this update.</param>
         /// <param name="settings">Settings to remove. If <c>null</c>, all settings will be removed.</param>
         /// <returns>A <see cref="IEnumerable{T}"/> of <see cref="SettingBase"/> instances that were successfully removed.</returns>
-        /// <remarks>This method is used to unsync settings from players. Using it with <see cref="Register(IEnumerable{SettingBase},Player)"/> provides an opportunity to update synced settings.</remarks>
+        /// <remarks>This method is used to unsync settings from players. Using it with <see cref="Register(Player,IEnumerable{SettingBase})"/> provides an opportunity to update synced settings.</remarks>
         public static IEnumerable<SettingBase> Unregister(Player player, IEnumerable<SettingBase> settings = null)
         {
             List<ServerSpecificSettingBase> list = ListPool<ServerSpecificSettingBase>.Pool.Get(ServerSpecificSettingsSync.DefinedSettings);

EXILED/Exiled.API/Features/Map.cs

@@ -382,19 +382,9 @@ public static void ExplodeEffect(Vector3 position, ProjectileType projectileType
         /// <param name="firearmType">The type of firearm to play the sound of.</param>
         /// <param name="maxDistance">The maximum distance the sound can be heard from.</param>
         /// <param name="audioClipId">The audio clip ID to play.</param>
+        [Obsolete("This method is not working. Use PlayGunSound(Player, Vector3, FirearmType, float, int, bool) overload instead.")]
         public static void PlayGunSound(Vector3 position, ItemType firearmType, byte maxDistance = 45, byte audioClipId = 0)
         {
-            // TODO: Not finish
-            /*
-            GunAudioMessage msg = new()
-            {
-                Weapon = firearmType,
-                AudioClipId = audioClipId,
-                MaxDistance = maxDistance,
-                ShooterHub = ReferenceHub._hostHub,
-                ShooterPosition = new RelativePosition(position),
-            };
-            msg.SendToAuthenticated();*/
         }
 
         /// <summary>

EXILED/Exiled.API/Features/Player.cs

@@ -3535,10 +3535,9 @@ public void Reconnect(ushort newPort = 0, float delay = 5, bool reconnect = true
         }
 
         /// <inheritdoc cref="MirrorExtensions.PlayGunSound(Player, Vector3, ItemType, byte, byte)"/>
-        [Obsolete("Use PlayGunSound(Player, Vector3, ItemType, byte, byte) instead.")]
+        [Obsolete("Use PlayGunSound(Player, Vector3, FirearmType, byte, byte) instead.")]
         public void PlayGunSound(ItemType type, byte volume, byte audioClipId = 0)
-        {
-        }
+            => PlayGunSound(type.GetFirearmType(), volume, audioClipId);
 
         /// <inheritdoc cref="MirrorExtensions.PlayGunSound(Player, Vector3, FirearmType, float, int)"/>
         public void PlayGunSound(FirearmType itemType, float pitch = 1, int clipIndex = 0) =>