feat: Added SpawnReasons and RoleSpawnFlags to CustomRole and some item/ammo fixes#570
Closed
Bonjemus wants to merge 10 commits into
Closed
feat: Added SpawnReasons and RoleSpawnFlags to CustomRole and some item/ammo fixes#570Bonjemus wants to merge 10 commits into
Bonjemus wants to merge 10 commits into
Conversation
## Description **Describe the changes** **What is the current behavior?** (You can also link to an open issue here) **What is the new behavior?** (if this is a feature change) **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?) **Other information**: <br /> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentations <br /> ## Submission checklist <!--- Put an `x` in all the boxes that apply: --> - [ ] I have checked the project can be compiled - [ ] I have tested my changes and it worked as expected ### Patches (if there are any changes related to Harmony patches) - [ ] I have checked no IL patching errors in the console ### Other - [ ] Still requires more testing
Author
|
I changed the name of the branch so I had to reopen it (again). |
louis1706
approved these changes
Jul 7, 2025
Collaborator
|
Looks good as long as it doesn't change default behavior 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Read title.
What is the current behavior? (You can also link to an open issue here)
Currently CustomRole always uses ForceClass as a SpawnReason and doesn't allow devs to specify RoleSpawnFlags.
Additionally, CustomRole behaviours when it comes to ammo and items was inconsistent so I also fixed it.
What is the new behavior? (if this is a feature change)
Read title.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Nope, some methods became obsolete though :
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other