fix: Customitems refactor#587
Closed
Bonjemus wants to merge 25 commits into
Closed
Conversation
## Description **Describe the changes** **What is the current behavior?** (You can also link to an open issue here) **What is the new behavior?** (if this is a feature change) **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?) **Other information**: <br /> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentations <br /> ## Submission checklist <!--- Put an `x` in all the boxes that apply: --> - [ ] I have checked the project can be compiled - [ ] I have tested my changes and it worked as expected ### Patches (if there are any changes related to Harmony patches) - [ ] I have checked no IL patching errors in the console ### Other - [ ] Still requires more testing
scale fix first attempt
2 attempt
3 attempt
4 attempt
Custolrole spawnreasonflags
Author
|
For unknown reasons some code that shouldn't have been there, is present, I'll try to remove it. |
Author
|
I'm bad with git, please forgive me. |
Author
|
Also, I merged into the wrong branch. |
Author
|
Please discard the changes related to CustomRole.cs and PlayerHandlers.cs, they shouldn't be here but I merged the wrong branch and I can't untangle it unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
custom items were janky and weird so I cleaned up a lot of useless shenanigans.
What is the current behavior? (You can also link to an open issue here)
CustomItems are constantly destroyed/spawned for no good reason. Dropping a customitem, picking it up, dying, escaping, etc. All of those events destroy custom items and spawn a new one with the same caracteristics which begs the question : Why do it in the first place ? As far as I'm aware this was introduced due to old limitation in SCP:SL which fortunately are no more. Consequently, I removed all of this junk.
One of the annoying consequences was that escaping would drop all of your customitems on the ground.
What is the new behavior? (if this is a feature change)
Old customitems : Beta virgin
New customitems : Yogurt male (rarer than sigma)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other