Skip to content

fix: firearms spawning with max ammo after being dropped#607

Closed
Someone-193 wants to merge 1 commit into
ExMod-Team:devfrom
Someone-193:I-understand-it-now
Closed

fix: firearms spawning with max ammo after being dropped#607
Someone-193 wants to merge 1 commit into
ExMod-Team:devfrom
Someone-193:I-understand-it-now

Conversation

@Someone-193

Copy link
Copy Markdown
Collaborator

Description

Describe the changes
Fixes bug

What is the current behavior? (You can also link to an open issue here)
All dropped guns spawn with max ammo, regardless of how much they should have

What is the new behavior? (if this is a feature change)
Only newly spawned guns spawned directly from Pickup.Create get max ammo

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
I have made a severe and continuous lapse in my judgement (I made PR that caused the bug)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

now only newly created firearm pickups have max ammo in mag (rather than all 😭 )
@github-actions github-actions Bot added the API label Aug 3, 2025
@louis1706 louis1706 closed this Aug 4, 2025
@Someone-193 Someone-193 deleted the I-understand-it-now branch December 20, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants