feat: Player::PreviousRole#751
Closed
louis1706 wants to merge 2 commits into
Closed
Conversation
Collaborator
|
You sure this works and everything? We might just wanna add a line about how the base game objects for that role (like the Base values) in theory should be in the role pool and thus unusable (because you could get somebody else's role on accident) |
Author
nope at all |
Someone-193
added
the
Requires Testing
louis1706
removed
the
Requires Testing
Author
|
tested: the rolebase are pooled so it's get reused by player that would take this role making it quite random working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.