feat: Dummy actions & making Npc wrapper useful#787
Conversation
Someone-193
left a comment
There was a problem hiding this comment.
Can I just rewrite these docs for you? You arent a native english speaker right? Anyways, I commented here on some of the docs you could improve, but there's a lot of little grammatical changes I would make
| /// <summary> | ||
| /// Forces Npc to look at certain point. | ||
| /// </summary> | ||
| /// <param name="dir">Position to look at.</param> |
There was a problem hiding this comment.
Bro pulled a yamato 💔
You are more then welcome. My English is not on a level that Exiled works with, so any gramatical changes are great. |
Someone-193
left a comment
There was a problem hiding this comment.
Ok I changed the docs myself. Verify this still works btw @Saskyc, I tried to use some better properties in TryMoveRelative
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
X
What is the new behavior? (if this is a feature change)
X
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No this PR only introduces new methods and properties.
Other information:
Test reporitory: https://github.com/Saskyc/ExiledTest/tree/Dummy-Action-Test
Youtube video showing new behaviour: https://www.youtube.com/watch?v=HjHgxjdN6tA
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other