Skip to content

feat: Changes to ReadPickupInfoBefore to include more information when converting between Pickup and Item. #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VALERA771 merged 2 commits into from
May 9, 2026
Merged

feat: Changes to ReadPickupInfoBefore to include more information when converting between Pickup and Item. #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0a47da
Changes to ReadPickupInfoBefore to include more information.
Saskyc Mar 27, 2026
af93e0e
fix: Build Error
louis1706 May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions EXILED/Exiled.API/Features/Items/Firearm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,10 @@ internal override void ReadPickupInfoBefore(Pickup pickup)
{
PrimaryMagazine.MaxAmmo = firearmPickup.MaxAmmo;
AmmoDrain = firearmPickup.AmmoDrain;
Damage = firearmPickup.Damage;
Inaccuracy = firearmPickup.Inaccuracy;
Penetration = firearmPickup.Penetration;
DamageFalloffDistance = firearmPickup.DamageFalloffDistance;
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions EXILED/Exiled.API/Features/Pickups/FirearmPickup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,26 @@ public uint Attachments
set => Base.Worldmodel.Setup(Base.CurId, Base.Worldmodel.WorldmodelType, value);
}

/// <summary>
/// Gets or sets the damage for this <see cref="FirearmPickup"/>.
/// </summary>
public float Damage { get; set; }

/// <summary>
/// Gets or sets the inaccuracy for this <see cref="FirearmPickup"/>.
/// </summary>
public float Inaccuracy { get; set; }

/// <summary>
/// Gets or sets the penetration for this <see cref="FirearmPickup"/>.
/// </summary>
public float Penetration { get; set; }

/// <summary>
/// Gets or sets how much fast the value drop over the distance.
/// </summary>
public float DamageFalloffDistance { get; set; }

Comment thread
louis1706 marked this conversation as resolved.
/// <summary>
/// Initializes the item as if it was spawned naturally by map generation.
/// </summary>
Expand All @@ -135,6 +155,10 @@ internal override void ReadItemInfo(Items.Item item)
{
MaxAmmo = firearm.PrimaryMagazine.ConstantMaxAmmo;
AmmoDrain = firearm.AmmoDrain;
Damage = firearm.Damage;
Inaccuracy = firearm.Inaccuracy;
Penetration = firearm.Penetration;
DamageFalloffDistance = firearm.DamageFalloffDistance;
}

base.ReadItemInfo(item);
Expand Down
Loading