Skip to content

fix: Fix a fix#840

Merged
Someone-193 merged 1 commit into
ExMod-Team:masterfrom
Someone-193:Fix-for-fix
May 31, 2026
Merged

fix: Fix a fix#840
Someone-193 merged 1 commit into
ExMod-Team:masterfrom
Someone-193:Fix-for-fix

Conversation

@Someone-193

Copy link
Copy Markdown
Collaborator

Description

Describe the changes
There's some weird bug apparently with picking up ammo? Anyways, the fix that was made for it can break other expected behaviors elsewhere. This change just makes the patch check if the ItemType is actually that of an ammo before running the different stuff

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

I don't know what the original bug this patch fixed was so I'd like to know how to recreate it so I can test it


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions Bot added Transpiler base-game-bug Bug from the main game labels May 31, 2026
@Someone-193 Someone-193 merged commit c7769a6 into ExMod-Team:master May 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base-game-bug Bug from the main game Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant