Skip to content

revert: Fixed Fix#843

Closed
MS-crew wants to merge 1 commit into
ExMod-Team:masterfrom
MS-crew:revertfix
Closed

revert: Fixed Fix#843
MS-crew wants to merge 1 commit into
ExMod-Team:masterfrom
MS-crew:revertfix

Conversation

@MS-crew

@MS-crew MS-crew commented Jun 2, 2026

Copy link
Copy Markdown

Description

Describe the changes
image

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions Bot added Transpiler base-game-bug Bug from the main game labels Jun 2, 2026
@Someone-193

Copy link
Copy Markdown
Collaborator

I can understand the PR, but I would like to point out that the TryRaycastRoom method is still kinda bad because if it detect an IRoomObject, it goes straight to the room in that object instead of running the other checks. I don't know if that's even a real concern, but maybe we'd want to change our patch to change that?

@louis1706

Copy link
Copy Markdown

I can understand the PR, but I would like to point out that the TryRaycastRoom method is still kinda bad because if it detect an IRoomObject, it goes straight to the room in that object instead of running the other checks. I don't know if that's even a real concern, but maybe we'd want to change our patch to change that?

our patch already does this

@louis1706 louis1706 closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base-game-bug Bug from the main game Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants