Skip to content

refactor: Obsolete VisiblePlayers#845

Merged
MS-crew merged 3 commits into
ExMod-Team:devfrom
MS-crew:patch-13
Jun 14, 2026
Merged

refactor: Obsolete VisiblePlayers#845
MS-crew merged 3 commits into
ExMod-Team:devfrom
MS-crew:patch-13

Conversation

@MS-crew

@MS-crew MS-crew commented Jun 10, 2026

Copy link
Copy Markdown

VisiblePlayers marked as obsolete

Description

Describe the changes

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Someone-193 Someone-193 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a breaking change because any plugins that DO try to use VisiblePlayers will get a NRE after this PR

@MS-crew MS-crew changed the base branch from master to dev June 12, 2026 17:04
@louis1706 louis1706 dismissed Someone-193’s stale review June 13, 2026 17:29

it's target dev branch so breaking change is expected

@MS-crew MS-crew merged commit 61d97d3 into ExMod-Team:dev Jun 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants