Skip to content

refactor: Obsolete VisiblePlayers #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MS-crew merged 3 commits into from
Jun 14, 2026
Merged

refactor: Obsolete VisiblePlayers #845

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f665293
Obsolete VisiblePlayers
MS-crew Jun 10, 2026
f45ffca
Remove unused using directive in Scp939Role.cs
MS-crew Jun 10, 2026
eae3c23
Update Scp939Role.cs
MS-crew Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions EXILED/Exiled.API/Features/Roles/Scp939Role.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace Exiled.API.Features.Roles
using System.Collections.Generic;

using Exiled.API.Enums;
using Exiled.API.Features.Pools;

using PlayerRoles;
using PlayerRoles.PlayableScps;
Expand Down Expand Up @@ -85,11 +84,6 @@ internal Scp939Role(Scp939GameRole baseRole)
MimicPointController = EnvironmentalMimicry._mimicPoint;
}

/// <summary>
/// Finalizes an instance of the <see cref="Scp939Role"/> class.
/// </summary>
~Scp939Role() => ListPool<Player>.Pool.Return(VisiblePlayers);

/// <inheritdoc/>
public override RoleTypeId Type { get; } = RoleTypeId.Scp939;

Expand Down Expand Up @@ -236,11 +230,6 @@ public float MimicryCooldown
/// </summary>
public Vector3? MimicryPointPosition => MimicPointController.Active ? MimicPointController.MimicPointTransform.position : null;

/// <summary>
/// Gets a list of players this SCP-939 instance can see regardless of their movement.
/// </summary>
public List<Player> VisiblePlayers { get; } = ListPool<Player>.Pool.Get();

/// <summary>
/// Gets the <see cref="Scp939GameRole"/> instance.
/// </summary>
Expand Down
Loading