docs: document missing config options and fix manager_path bug#343
Open
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
docs: document missing config options and fix manager_path bug#343staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Add documentation for the following config options that were missing from the README: - quiet: suppress completion error notifications - enable_local_search: enable local search in language server - enable_index_service: enable index service for workspace search - search_max_workspace_file_count: max files for search indexing - file_watch_max_dir_count: max directories for file watching - manager_path: custom language server manager directory - language_server_download_url: base URL for LS binary download Fix bug in api.lua where config.manager_path was used instead of config.options.manager_path, causing user-provided manager_path to be silently ignored. Co-Authored-By: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
Author
Original prompt from Ido
|
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes:
README: Added documentation for 7 config options defined in
lua/codeium/config.luathat were missing from the README:manager_path,language_server_download_url,quiet,enable_local_search,enable_index_service,search_max_workspace_file_count, andfile_watch_max_dir_count.Bug fix (
lua/codeium/api.lua):config.manager_path→config.options.manager_path. The old code accessed a non-existent field on the config module, so user-providedmanager_pathwas silently ignored and the server always used a temp directory.Review & Testing Checklist for Human
manager_pathbug fix doesn't break existing behavior: Before this fix,manager_pathalways resolved tonil(temp dir fallback). After this fix, if a user hadmanager_pathset in their config, it would actually be used. Confirm no downstream code assumes the manager dir is always a temp directory.lua/codeium/config.luadefaults and the consuming code inapi.lua/update.lua.manager_pathto a custom directory in your Neovim config, restart, and confirm the language server uses that directory instead of a temp one.Notes
Link to Devin session: https://localhost:3000/sessions/7c4051b3ecdf4ac3a8b3516012aae980
Requested by: @IdoPesok