Skip to content

Switch to eqx#18

Merged
hvater merged 15 commits into
mainfrom
switch-to-eqx
May 15, 2026
Merged

Switch to eqx#18
hvater merged 15 commits into
mainfrom
switch-to-eqx

Conversation

@hvater

@hvater hvater commented Feb 25, 2026

Copy link
Copy Markdown
Collaborator

Migrated from jax_dataclasses to equinox for states etc.

Additionally, cleaned up the vmapping procedure

@hvater hvater left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I really like the changes. Nice work!

Please look at the comments and implement the suggestions. If you have any questions/differing opinions, I am open for discussion.

Comment thread exciting_environments/core_env.py
Comment thread exciting_environments/core_env.py Outdated
Comment thread exciting_environments/core_env.py Outdated
Comment thread exciting_environments/core_env.py
Comment thread exciting_environments/pmsm/motor_parameters.py Outdated
Comment thread examples/env_functions_examples.ipynb Outdated
Comment thread examples/env_functions_examples.ipynb
Comment thread examples/env_functions_examples.ipynb Outdated
Comment thread exciting_environments/acrobot/acrobot_env.py
Comment thread exciting_environments/fluid_tank/fluid_tank_env.py
@hvater hvater requested a review from OliverSchw March 20, 2026 09:49

@OliverSchw OliverSchw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have revised the points raised and also changed the LUT interpolator structure.

@OliverSchw OliverSchw requested review from OliverSchw and removed request for OliverSchw March 26, 2026 10:06
@hvater hvater merged commit 8578560 into main May 15, 2026
2 checks passed
@hvater hvater deleted the switch-to-eqx branch June 29, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants