Skip to content

Commit 255b9db

Browse files
committed
【修改信息】 bug fix
1 parent a449737 commit 255b9db

12 files changed

Lines changed: 56 additions & 33 deletions

File tree

ZLGitHubClient/Podfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,20 @@ pod "SYDCentralPivot"
1818
pod 'ZLGithubOAuth', :git => 'https://github.com/ExistOrLive/ZLGithubOAuth.git', :tag => "1.3.1"
1919
#pod "ZLGithubOAuth", :path => '../../ZLGithubOAuth'
2020

21-
pod 'ZLGitRemoteService', :git => 'https://github.com/ExistOrLive/ZLGitRemoteService.git'
21+
pod 'ZLGitRemoteService', :git => 'https://github.com/ExistOrLive/ZLGitRemoteService.git', :tag => "1.8.0"
2222
#pod "ZLGitRemoteService", :path => '../../ZLGitRemoteService'
2323

2424
pod 'ZLBaseExtension', :git => "https://github.com/ExistOrLive/ZLBaseExtension.git", :tag => "1.3.0"
2525
#pod 'ZLBaseExtension', :path => "../../ZLBaseExtension"
2626

27-
pod 'ZLUIUtilities', :git => "https://github.com/ExistOrLive/ZLUIUtilities.git", :tag => "1.3.0"
27+
pod 'ZLUIUtilities', :git => "https://github.com/ExistOrLive/ZLUIUtilities.git", :tag => "1.8.0"
2828
#pod 'ZLUIUtilities', :path => "../../ZLUIUtilities"
2929

3030
#pod 'ZLUtilities', :path => '../../ZLUtilities'
31-
pod 'ZLUtilities', :git => "https://github.com/ExistOrLive/ZLUtilities.git"
31+
pod 'ZLUtilities', :git => "https://github.com/ExistOrLive/ZLUtilities.git", :tag => "1.8.0"
3232

3333
#pod 'ZMMVVM', :path => '../../ZMMVVM'
34-
pod 'ZMMVVM', :git => "https://github.com/ExistOrLive/ZMMVVM.git", :tag => "1.3.0"
34+
pod 'ZMMVVM', :git => "https://github.com/ExistOrLive/ZMMVVM.git", :tag => "1.8.0"
3535

3636
pod 'Umbrella'
3737
pod 'Umbrella/Firebase'

ZLGitHubClient/Podfile.lock

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ PODS:
215215
- Alamofire
216216
- SnapKit
217217
- ZLUIUtilities
218-
- ZLGitRemoteService (1.7.1):
218+
- ZLGitRemoteService (1.8.0):
219219
- Alamofire
220220
- Apollo (~> 0.39.0)
221221
- CocoaLumberjack
@@ -225,20 +225,20 @@ PODS:
225225
- ObjectMapper
226226
- SYDCentralPivot
227227
- ZLUtilities
228-
- ZLUIUtilities (1.3.0):
228+
- ZLUIUtilities (1.8.0):
229229
- MBProgressHUD
230230
- MJRefresh
231231
- SnapKit
232232
- Toast-Swift
233233
- ZLBaseExtension
234234
- ZLUtilities
235235
- ZMMVVM
236-
- ZLUtilities (1.3.0):
236+
- ZLUtilities (1.8.0):
237237
- Firebase/Analytics
238238
- ObjectMapper
239239
- Umbrella
240240
- Umbrella/Firebase
241-
- ZMMVVM (1.3.0):
241+
- ZMMVVM (1.8.0):
242242
- SnapKit
243243

244244
DEPENDENCIES:
@@ -269,10 +269,10 @@ DEPENDENCIES:
269269
- YYText
270270
- ZLBaseExtension (from `https://github.com/ExistOrLive/ZLBaseExtension.git`, tag `1.3.0`)
271271
- ZLGithubOAuth (from `https://github.com/ExistOrLive/ZLGithubOAuth.git`, tag `1.3.1`)
272-
- ZLGitRemoteService (from `https://github.com/ExistOrLive/ZLGitRemoteService.git`)
273-
- ZLUIUtilities (from `https://github.com/ExistOrLive/ZLUIUtilities.git`, tag `1.3.0`)
274-
- ZLUtilities (from `https://github.com/ExistOrLive/ZLUtilities.git`)
275-
- ZMMVVM (from `https://github.com/ExistOrLive/ZMMVVM.git`, tag `1.3.0`)
272+
- ZLGitRemoteService (from `https://github.com/ExistOrLive/ZLGitRemoteService.git`, tag `1.8.0`)
273+
- ZLUIUtilities (from `https://github.com/ExistOrLive/ZLUIUtilities.git`, tag `1.8.0`)
274+
- ZLUtilities (from `https://github.com/ExistOrLive/ZLUtilities.git`, tag `1.8.0`)
275+
- ZMMVVM (from `https://github.com/ExistOrLive/ZMMVVM.git`, tag `1.8.0`)
276276

277277
SPEC REPOS:
278278
trunk:
@@ -331,14 +331,16 @@ EXTERNAL SOURCES:
331331
:tag: 1.3.1
332332
ZLGitRemoteService:
333333
:git: https://github.com/ExistOrLive/ZLGitRemoteService.git
334+
:tag: 1.8.0
334335
ZLUIUtilities:
335336
:git: https://github.com/ExistOrLive/ZLUIUtilities.git
336-
:tag: 1.3.0
337+
:tag: 1.8.0
337338
ZLUtilities:
338339
:git: https://github.com/ExistOrLive/ZLUtilities.git
340+
:tag: 1.8.0
339341
ZMMVVM:
340342
:git: https://github.com/ExistOrLive/ZMMVVM.git
341-
:tag: 1.3.0
343+
:tag: 1.8.0
342344

343345
CHECKOUT OPTIONS:
344346
MBProgressHUD:
@@ -351,17 +353,17 @@ CHECKOUT OPTIONS:
351353
:git: https://github.com/ExistOrLive/ZLGithubOAuth.git
352354
:tag: 1.3.1
353355
ZLGitRemoteService:
354-
:commit: a97300c794ac7fa347363ea1c6a47110f43e0fe9
355356
:git: https://github.com/ExistOrLive/ZLGitRemoteService.git
357+
:tag: 1.8.0
356358
ZLUIUtilities:
357359
:git: https://github.com/ExistOrLive/ZLUIUtilities.git
358-
:tag: 1.3.0
360+
:tag: 1.8.0
359361
ZLUtilities:
360-
:commit: 9bb195a37c432111e3ecee6c45e887097c137943
361362
:git: https://github.com/ExistOrLive/ZLUtilities.git
363+
:tag: 1.8.0
362364
ZMMVVM:
363365
:git: https://github.com/ExistOrLive/ZMMVVM.git
364-
:tag: 1.3.0
366+
:tag: 1.8.0
365367

366368
SPEC CHECKSUMS:
367369
Alamofire: f36a35757af4587d8e4f4bfa223ad10be2422b8c
@@ -410,11 +412,11 @@ SPEC CHECKSUMS:
410412
YYText: 5c461d709e24d55a182d1441c41dc639a18a4849
411413
ZLBaseExtension: b19ba7680506b4e3211ec31dac27f2355f189845
412414
ZLGithubOAuth: 19f4b9c205ff550131f004a140e09e0f5f9f3ae7
413-
ZLGitRemoteService: 5d98f351b2b762782aa4fe736f3f33aa9dfa3cca
414-
ZLUIUtilities: 4971f48f43971fe39eb65832abb47af68d21a9de
415-
ZLUtilities: cc526fb2d1a47ca55345cc2dc03ed05f11068bf7
416-
ZMMVVM: 92ef04990cd7d0ae5bb3ea9ddf778023bc5c5d9e
415+
ZLGitRemoteService: e7fda9ae61a2ceba4cbc3f5101dbfb175cfce236
416+
ZLUIUtilities: d5a61d55d1318b8b53c0c1948a920c7d72591bdd
417+
ZLUtilities: 4fb9c6da4c56277195f4f429e2772e72651d3015
418+
ZMMVVM: be8e6ae251edb9b72461d1a1c3db446f540afe9d
417419

418-
PODFILE CHECKSUM: 02f7d71cdf50a85dbc6c1cd9f993df797bc9885a
420+
PODFILE CHECKSUM: f4ae50a18b144463982bc588250ed26561c2c222
419421

420422
COCOAPODS: 1.16.2

ZLGitHubClient/ZLGitHubClient/Class/UI/Commit/ZLCommitInfoController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class ZLCommitInfoController: ZMTableViewController {
8989
override func setupUI() {
9090
super.setupUI()
9191

92-
self.title = "\(ZLLocalizedString(string: "Commit", comment: "提交")) #\(ref?.prefix(7) ?? "")"
92+
self.title = "\(ZLLocalizedString(string: "commit", comment: "提交")) #\(ref?.prefix(7) ?? "")"
9393

9494
self.zmNavigationBar.addRightView(moreButton)
9595

ZLGitHubClient/ZLGitHubClient/Class/UI/Commit/ZLCompareCommitFilesController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class ZLCompareCommitFilesController: ZMTableViewController {
8181
override func setupUI() {
8282
super.setupUI()
8383

84-
self.title = ZLLocalizedString(string: "commits", comment: "提交")
84+
self.title = ZLLocalizedString(string: "File Diff", comment: "文件差异")
8585

8686

8787
tableView.register(ZLCommitInfoPatchCell.self,

ZLGitHubClient/ZLGitHubClient/Class/UI/Discussion/ZLDiscussionInfoController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class ZLDiscussionInfoController: ZMTableViewController {
4747
override func setupUI() {
4848
super.setupUI()
4949

50-
self.title = "\(ZLLocalizedString(string: "Discussions", comment: "讨论")) #\(number)"
50+
self.title = "\(ZLLocalizedString(string: "Discussion", comment: "讨论")) #\(number)"
5151

5252
self.zmNavigationBar.addRightView(moreButton)
5353

ZLGitHubClient/ZLGitHubClient/Class/UI/Release/ZLReleaseInfoController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class ZLReleaseInfoController: ZMTableViewController {
4949
override func setupUI() {
5050
super.setupUI()
5151

52-
self.title = "\(ZLLocalizedString(string: "Releases", comment: "发行版")) \(tagName ?? "")"
52+
self.title = "\(ZLLocalizedString(string: "Release", comment: "发行版")) \(tagName ?? "")"
5353

5454
self.zmNavigationBar.addRightView(moreButton)
5555

ZLGitHubClient/ZLGitHubClient/Class/UI/ZLReuseView/ZLIssueTableViewCell/viewModel/ZLIssueTimelineTableViewCellData.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import UIKit
1010
import ZLBaseExtension
1111
import ZLGitRemoteService
1212
import ZMMVVM
13+
import ZLUtilities
1314

1415
class ZLIssueTimelineTableViewCellData: ZMBaseTableViewCellViewModel {
1516

@@ -427,6 +428,9 @@ extension ZLIssueTimelineTableViewCellData: ZLIssueTimelineTableViewCellDelegate
427428
return string
428429
}
429430

431+
analytics.log(.unknownIssueTimelineType(type: data.__typename))
432+
433+
430434
return NSAttributedString(string: data.__typename,
431435
attributes: [.font: UIFont.zlSemiBoldFont(withSize: 15),
432436
.foregroundColor: UIColor.label(withName: "ZLLabelColor1")])

ZLGitHubClient/ZLGitHubClient/Class/UI/ZLReuseView/ZLPullRequestTableViewCell/viewmodel/ZLPullRequestTimelineTableViewCellData.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import UIKit
1010
import ZLBaseExtension
1111
import ZLGitRemoteService
1212
import ZMMVVM
13+
import ZLUtilities
1314

1415
class ZLPullRequestTimelineTableViewCellData: ZMBaseTableViewCellViewModel {
1516

@@ -493,6 +494,8 @@ extension ZLPullRequestTimelineTableViewCellData: ZLPullRequestTimelineTableView
493494
return string
494495

495496
}
497+
498+
analytics.log(.unknownPrTimelineType(type: data.__typename))
496499

497500
return NSAttributedString(string: data.__typename,
498501
attributes: [.font: UIFont.zlSemiBoldFont(withSize: 15),

ZLGitHubClient/ZLGitHubClient/Class/UI/issue/ZLIssueInfoController/ViewController/ZLIssueInfoController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class ZLIssueInfoController: ZMTableViewController {
5353
super.setupUI()
5454

5555

56-
self.title = "\(ZLLocalizedString(string: "issues", comment: "合并请求")) #\(number)"
56+
self.title = "\(ZLLocalizedString(string: "issue", comment: "合并请求")) #\(number)"
5757

5858
self.zmNavigationBar.addRightView(moreButton)
5959

ZLGitHubClient/ZLGitHubClient/Class/UI/repo/ZLRepoForkedReposController/Controller/ZLRepoForkedReposController.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ class ZLRepoForkedReposController: ZMTableViewController {
3030
super.setupUI()
3131

3232
title = ZLLocalizedString(string: "fork", comment: "")
33-
title = ZLLocalizedString(string: "star", comment: "标星")
3433

3534
tableView.contentInsetAdjustmentBehavior = .automatic
3635
tableView.contentInset = UIEdgeInsets(top: 5, left: 0, bottom: 0, right: 0)

0 commit comments

Comments
 (0)