Fix copy-paste error in WebPImage::inject_VP8X height check (backport #9280)#9314
Open
mergify[bot] wants to merge 1 commit into
Open
Fix copy-paste error in WebPImage::inject_VP8X height check (backport #9280)#9314mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9279:
Line 773 checks width > 0 instead of height > 0. This was introduced in commit bf151a1. When height is 0, the enforce does not catch it and height - 1 wraps as an unsigned integer.
Change the check to validate height instead of width.
This is an automatic backport of pull request #9280 done by Mergify.