feat: populate verifyContext from core.verify.resolve attestation#2
Merged
Conversation
exodus-jee
force-pushed
the
jee/feat/enable-verify-api
branch
from
May 12, 2026 10:07
942d4d0 to
51574f6
Compare
exodus-jee
marked this pull request as draft
May 12, 2026 14:57
exodus-jee
force-pushed
the
jee/feat/enable-verify-api
branch
2 times, most recently
from
May 12, 2026 21:31
81bd358 to
dddbc5e
Compare
exodus-jee
force-pushed
the
jee/feat/enable-verify-api
branch
from
May 12, 2026 21:46
dddbc5e to
5206428
Compare
exodus-jee
marked this pull request as ready for review
May 12, 2026 22:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror the
getVerifyContextactivation fromExodusForks/walletconnect-monorepoinauth-client/src/controllers/engine.ts, so auth_request flows populateverifyContext.verified.{origin, validation, isScam}fromcore.verify.resolveinstead of always returningvalidation: "UNKNOWN".Dependency
Requires
ExodusForks/walletconnect-monorepo#24(which re-enablescore.verify.resolve) to be published first; otherwiseresolvestill throws.Test plan
verified.validationcontentvalidation === "UNKNOWN"still hold (test attestations 404 -> caught ->UNKNOWN)