Skip to content

Commit ec7fc50

Browse files
authored
fix: load correct prod version of hermes & use any cmake version (#24)
* fix: load correct prod version of hermes * fix: drop CMake version requirements * fix: go up one more level in search for exodus hermes engine
1 parent 8c87e58 commit ec7fc50

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

packages/react-native-reanimated/android/build.gradle

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,10 @@ android {
270270
}
271271
externalNativeBuild {
272272
cmake {
273-
version = System.getenv("CMAKE_VERSION") ?: "3.22.1"
273+
// We'll let the build system to resolve the version of CMake
274+
// but keeping this here as a reminder that you should actually
275+
// match the version being used in the React Native repo
276+
// version = System.getenv("CMAKE_VERSION") ?: "3.22.1"
274277
path "CMakeLists.txt"
275278
}
276279
}
@@ -518,7 +521,12 @@ dependencies {
518521

519522
implementation "com.facebook.react:react-android" // version substituted by RNGP
520523
if (JS_RUNTIME == "hermes") {
521-
implementation "com.facebook.react:hermes-android" // version substituted by RNGP
524+
if (System.getenv("BUILD_TYPE") == "release") {
525+
def hermesPath = "../../../@exodus/hermes-engine/android/";
526+
releaseImplementation files(hermesPath + "hermes-release.aar")
527+
} else {
528+
implementation("com.facebook.react:hermes-android")
529+
}
522530
}
523531
}
524532

0 commit comments

Comments
 (0)