refactor: remove eval#22
Closed
alexandrius wants to merge 1 commit into
Closed
Conversation
alexandrius
requested review from
633kh4ck,
joshua-rogers-exodus,
kewde and
mvayngrib
alexandrius
commented
Mar 28, 2025
alexandrius
commented
Mar 28, 2025
| const jsi::Value &thisValue, | ||
| const jsi::Value *args, | ||
| size_t count) -> jsi::Value { | ||
| auto code = std::make_shared<const jsi::StringBuffer>("("+WorkletStore::getInstance().get(args[0].asNumber())+"\n)"); |
Author
There was a problem hiding this comment.
grab the function from the store
alexandrius
commented
Mar 28, 2025
| const reanimatedWorkletCodeProperty = objectProperty( | ||
| identifier('__reanimated_workletCodeWrapper'), | ||
| objectExpression([workletCodeProperty]) | ||
| objectExpression([workletCodeProperty, workletHashProperty]) |
Author
There was a problem hiding this comment.
add hash to our wrapper for easy access in Shareables.CPP
alexandrius
commented
Mar 29, 2025
| auto code = object.getProperty(rt, prop).asString(rt).utf8(rt); | ||
| double hash = object.getProperty(rt,jsi::String::createFromUtf8(rt,"hash")).asNumber(); | ||
| WorkletStore::getInstance().set(hash, code); | ||
| shareable = std::make_shared<ShareableString>(""); |
alexandrius
commented
Mar 29, 2025
| auto code = object.getProperty(rt, prop).asString(rt).utf8(rt); | ||
| double hash = object.getProperty(rt,jsi::String::createFromUtf8(rt,"hash")).asNumber(); | ||
| WorkletStore::getInstance().set(hash, code); | ||
| shareable = std::make_shared<ShareableString>(""); |
Author
|
Closing in favor of #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stores JS worklet code on in the CPP map.
The evaluation of the function is now triggered by the unique hashvalue.
Removes access to JS code evaluation
Test plan