Skip to content

refactor: resurrect dispatchCommand #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvayngrib merged 1 commit into from
Apr 2, 2025
Merged

refactor: resurrect dispatchCommand #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...es/react-native-reanimated/Common/cpp/reanimated/RuntimeDecorators/UIRuntimeDecorator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ void UIRuntimeDecorator::decorate(
jsi_utils::installJsiFunction(uiRuntime, "_updatePropsFabric", updateProps);
jsi_utils::installJsiFunction(
uiRuntime, "_removeFromPropsRegistry", removeFromPropsRegistry);
// jsi_utils::installJsiFunction(
// uiRuntime, "_dispatchCommandFabric", dispatchCommand);
jsi_utils::installJsiFunction(
uiRuntime, "_dispatchCommandFabric", dispatchCommand);
jsi_utils::installJsiFunction(uiRuntime, "_measureFabric", measure);
#else
jsi_utils::installJsiFunction(uiRuntime, "_updatePropsPaper", updateProps);
// jsi_utils::installJsiFunction(
// uiRuntime, "_dispatchCommandPaper", dispatchCommand);
jsi_utils::installJsiFunction(
uiRuntime, "_dispatchCommandPaper", dispatchCommand);
jsi_utils::installJsiFunction(uiRuntime, "_scrollToPaper", scrollTo);
jsi_utils::installJsiFunction(
uiRuntime,
Expand Down
16 changes: 3 additions & 13 deletions packages/react-native-reanimated/src/platformFunctions/dispatchCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
// import type { ShadowNodeWrapper } from '../commonTypes';
import type { ShadowNodeWrapper } from '../commonTypes';
import {
isChromeDebugger,
isFabric,
Expand Down Expand Up @@ -36,39 +36,29 @@ export let dispatchCommand: DispatchCommand;
function dispatchCommandFabric(
animatedRef: AnimatedRefOnJS | AnimatedRefOnUI,
commandName: string,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
args: Array<unknown> = []
) {
/* 'worklet';
'worklet';
if (!_WORKLET) {
return;
}

const shadowNodeWrapper = animatedRef() as ShadowNodeWrapper;
global._dispatchCommandFabric!(shadowNodeWrapper, commandName, args);
*/
logger.warn(
'dispatchCommand() is disabled: https://github.com/ExodusMovement/exodus-mobile/pull/24699. Contact AppSec if you need this.'
);
}

function dispatchCommandPaper(
animatedRef: AnimatedRefOnJS | AnimatedRefOnUI,
commandName: string,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
args: Array<unknown> = []
) {
/* 'worklet';
'worklet';
if (!_WORKLET) {
return;
}

const viewTag = animatedRef() as number;
global._dispatchCommandPaper!(viewTag, commandName, args);
*/
logger.warn(
'dispatchCommand() is disabled: https://github.com/ExodusMovement/exodus-mobile/pull/24699. Contact AppSec if you need this.'
);
}

function dispatchCommandJest() {
Expand Down
Loading