Skip to content

fix: load correct prod version of hermes & use any cmake version#24

Merged
kewde merged 3 commits into
exodus-3.16.7from
kewde/fix-load-correct-hermes-impl
Apr 7, 2025
Merged

fix: load correct prod version of hermes & use any cmake version#24
kewde merged 3 commits into
exodus-3.16.7from
kewde/fix-load-correct-hermes-impl

Conversation

@kewde
Copy link
Copy Markdown

@kewde kewde commented Apr 4, 2025

Summary

  1. We should load the custom hermes build for inclusion during prod builds.
  2. Let's drop the cmake version requirements for now, seems like nobody is building with 3.22.1 in our org, seems a bit of everything lol, let's roll the dice with that one.

@kewde kewde changed the title fix: load correct prod version of hermes fix: load correct prod version of hermes & use any cmake version Apr 4, 2025
alexandrius
alexandrius approved these changes Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown

@alexandrius alexandrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kewde kewde merged commit ec7fc50 into exodus-3.16.7 Apr 7, 2025
5 checks passed
@kewde kewde deleted the kewde/fix-load-correct-hermes-impl branch April 7, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexandrius alexandrius alexandrius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kewde @alexandrius