fix: skia crash#27
Merged
Merged
Conversation
alexandrius
commented
Apr 24, 2025
| auto object = value.asObject(rt); | ||
| jsi::PropNameID prop = workletCodePropName(rt); | ||
| if (object.hasProperty(rt, prop)) { | ||
| if (object.hasProperty(rt, prop) && object.getPropertyNames(rt).length(rt) == 0) { |
Author
There was a problem hiding this comment.
compare to 0 since Symbol isn't accounted for
kewde
approved these changes
Apr 24, 2025
kewde
left a comment
kewde
left a comment
There was a problem hiding this comment.
utACK
will revisit, still don't understand it a 100% though
mvayngrib
approved these changes
Apr 24, 2025
|
|
Author
|
@kewde yeah me neither. This is just symptom workaround not the cause. Works perfectly though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skia has some advanced integration with reanimated.
__reanimated_workletCodeis somewhere attached to the already UI runtime compatible skia code. Which causes our code misbehave. I added additional check to make sure worklet code is only property in the object.@kewde will know much better but this trick fixes the problem