drop node-fetch and simplify codebase

Author: ChALkeR

README.md

@@ -1,12 +1,4 @@
 # @exodus/fetch
 
-A small wrapper around global fetch and `node-fetch`:
-
-1. In React Native, global `fetch` is used without importing `node-fetch`
-
-2. In Browser, global `fetch` is used without importing `node-fetch`
-
-3. Otherwise `node-fetch` is imported, but when `window.fetch` is present (e.g. in Electron
-   `renderer` process), it is used.
-
-4. Otherwise (e.g. in Electron `browser` process and Node.js), `node-fetch` is used.
+Using this as a wrapper for `node-fetch` is deprecated,
+since all active Node.js versions implement global `fetch`

create-fetchival.js

@@ -8,7 +8,7 @@ function query(params) {
     .join('&')}`
 }
 
-function createFetchival({ fetch }) {
+function createFetchival({ fetch = require('./fetch') } = {}) {
   async function _fetch(method, url, opts, data) {
     // Unlike fetchival, don't silently ignore and override
     if (opts.body) throw new Error('unexpected pre-set body option')

fetch.browser.js

@@ -1,20 +1,6 @@
 'use strict'
 
-// This file is structured this way to allow webpack to optimize out
-// the require calls based on hardcoded process.type per bundle.
-// Do not refactor or deduplicate.
+// This is deprecated, just use global fetch instead
+// All supported Node.js versions have it, and the only fallback here was node-fetch
 
-// Try to use global browser APIs (e.g. if in Electron), otherwise require impls
-if (typeof process !== 'undefined' && process) {
-  // Node.js or Electron with Node.js integration
-  if (process.type === 'renderer' || process.type === 'worker') {
-    // Electron renderer with Node.js integration
-    module.exports = fetch
-  } else {
-    // Node.js or Electron browser process
-    module.exports = typeof fetch === 'undefined' ? require('node-fetch') : fetch.bind(globalThis)
-  }
-} else {
-  // Browser or Electron without Node.js integration
-  module.exports = fetch
-}
+module.exports = globalThis.fetch.bind(globalThis)

fetch.js

@@ -1,6 +1,3 @@
-const fetchival = require('./fetchival.browser')
-const fetch = require('./fetch')
+const createFetchival = require('./create-fetchival')
 
-if (!fetchival.fetch) fetchival.fetch = fetch
-
-module.exports = fetchival
+module.exports = createFetchival()

fetch.native.js

@@ -1,9 +1,10 @@
 'use strict'
 
-// Don't need to require node-fetch here, global fetch is defined
-// Same for global WebSocket
+// NOTE: use targeted imports in new code, main import is deprecated
 
-const fetchival = require('./fetchival.browser.js')
-const fetch = require('./fetch.browser.js')
+// Don't need to require ws here, global WebSocket is defined
+
+const fetchival = require('./fetchival.js')
+const fetch = require('./fetch.js')
 
 module.exports = { fetch, WebSocket, fetchival }

fetchival.browser.js

@@ -1,6 +1,6 @@
 'use strict'
 
-// NOTE: use targeted imports in new code
+// NOTE: use targeted imports in new code, main import is deprecated
 
 const fetch = require('./fetch')
 const WebSocket = require('./websocket')