Skip to content

Commit a441b6d

Browse files
committed
test: better document some issues
1 parent 506d8f6 commit a441b6d

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

tests/encoding/mistakes.test.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,12 +273,13 @@ describe('Common implementation mistakes', () => {
273273
describe('Push back ASCII characters on errors', () => {
274274
const vectors = {
275275
big5: [
276-
[[0x81, 0x40], '\uFFFD@'], // WebKit fails on this
277-
[[0x83, 0x5c], '\uFFFD\x5C'], // https://github.com/nodejs/node/issues/40091#issue-994273867
278-
[[0x87, 0x87, 0x40], '\uFFFD@'], // Chrome fails on this
276+
[[0x81, 0x40], '\uFFFD@'], // WebKit fails: https://bugs.webkit.org/show_bug.cgi?id=304238. Chrome and Firefox are correct. Node.js fails (see below)
277+
[[0x83, 0x5c], '\uFFFD\x5C'], // Node.js fails: https://github.com/nodejs/node/issues/40091. Chrome and Firefox are correct. WebKit fails (see above)
278+
[[0x87, 0x87, 0x40], '\uFFFD@'], // Chrome fails: https://issues.chromium.org/issues/467727340. Firefox and WebKit are correct
279+
[[0x81, 0x81], '\uFFFD'], // Chrome fails: https://issues.chromium.org/issues/467727340. Firefox and WebKit are correct
279280
],
280281
'iso-2022-jp': [
281-
[[0x1b, 0x24], '\uFFFD$'], // Node.js fails on this
282+
[[0x1b, 0x24], '\uFFFD$'], // Node.js fails on this. Chrome, Firefox and Safari are correct
282283
[[0x1b, 0x24, 0x40, 0x1b, 0x24], '\uFFFD\uFFFD'], // Last 0x24 is invalid on both attemtps. Chrome fails on this
283284
],
284285
// TODO: more vectors?

0 commit comments

Comments
 (0)