some lint fixes

Author: ChALkeR

base64.js

@@ -82,7 +82,7 @@ const { atob } = globalThis
 function fromBase64common(arg, isBase64url) {
   if (Uint8Array.fromBase64) {
     const options = { alphabet: isBase64url ? 'base64url' : 'base64', lastChunkHandling: 'strict' }
-    const padded = arg.length % 4 !== 0 ? `${arg}${'='.repeat(4 - (arg.length % 4))}` : arg
+    const padded = arg.length % 4 > 0 ? `${arg}${'='.repeat(4 - (arg.length % 4))}` : arg
     return Uint8Array.fromBase64(padded, options)
   }
 
@@ -139,9 +139,11 @@ function toBase64js(arr, alphabet, padding) {
       shift = 0
       o += alphabet[x & 0x3f]
     }
+
     carry = (x << (6 - shift)) & 0x3f
     shift += 2 // Each byte prints 6 bits and leaves 2 bits
   }
+
   if (shift !== 2) o += alphabet[carry] // shift 2 means we have no carry left
   if (padding) o += ['', '==', '='][arr.length - fullChunksBytes]
 
@@ -150,8 +152,9 @@ function toBase64js(arr, alphabet, padding) {
 
 // Assumes no chars after =, checked
 let fromBase64jsMap
+
 function fromBase64js(str) {
-  const map = fromBase64jsMap || Array(256)
+  const map = fromBase64jsMap || new Array(256)
   if (!fromBase64jsMap) {
     fromBase64jsMap = map
     BASE64.forEach((c, i) => (map[c.charCodeAt(0)] = i))

benchmarks/base64.bench.js

@@ -7,7 +7,7 @@ import { bufs } from './random.js'
 
 if (!globalThis.Buffer) globalThis.Buffer = buffer.Buffer
 Buffer.TYPED_ARRAY_SUPPORT = true
-const exodusPure = await import('../base64.js?pure')
+const exodusPure = await import('../base64.js?pure') // eslint-disable-line @exodus/import/no-unresolved
 delete Buffer.TYPED_ARRAY_SUPPORT
 
 const val = exodus.toBase64(bufs[0])

benchmarks/base64.from.bench.js

@@ -7,10 +7,10 @@ import { bufs } from './random.js'
 
 if (!globalThis.Buffer) globalThis.Buffer = buffer.Buffer
 Buffer.TYPED_ARRAY_SUPPORT = true
-const exodusAtob = await import('../base64.js?atob')
+const exodusAtob = await import('../base64.js?atob') // eslint-disable-line @exodus/import/no-unresolved
 const { atob } = globalThis
 delete globalThis.atob
-const exodusPure = await import('../base64.js?pure')
+const exodusPure = await import('../base64.js?pure') // eslint-disable-line @exodus/import/no-unresolved
 globalThis.atob = atob
 delete Buffer.TYPED_ARRAY_SUPPORT
 

benchmarks/hex.bench.js

@@ -6,7 +6,7 @@ import { bufs } from './random.js'
 
 if (!globalThis.Buffer) globalThis.Buffer = buffer.Buffer
 Buffer.TYPED_ARRAY_SUPPORT = true
-const exodusPure = await import('../hex.js?pure')
+const exodusPure = await import('../hex.js?pure') // eslint-disable-line @exodus/import/no-unresolved
 delete Buffer.TYPED_ARRAY_SUPPORT
 
 const val = exodus.toHex(bufs[0])

benchmarks/hex.from.bench.js

@@ -6,7 +6,7 @@ import { bufs } from './random.js'
 
 if (!globalThis.Buffer) globalThis.Buffer = buffer.Buffer
 Buffer.TYPED_ARRAY_SUPPORT = true
-const exodusPure = await import('../hex.js?pure')
+const exodusPure = await import('../hex.js?pure') // eslint-disable-line @exodus/import/no-unresolved
 delete Buffer.TYPED_ARRAY_SUPPORT
 
 const strings = bufs.map((x) => exodus.fromTypedArray(x, 'hex'))

hex.js

@@ -16,6 +16,7 @@ export function toHex(arr) {
     if (arr.constructor === Buffer && Buffer.isBuffer(arr)) return arr.toString('hex')
     return Buffer.from(arr.buffer, arr.byteOffset, arr.byteLength).toString('hex')
   }
+
   if (!hexArray) hexArray = Array.from({ length: 256 }, (_, i) => i.toString(16).padStart(2, '0'))
   let out = ''
   for (let i = 0; i < arr.length; i++) out += hexArray[u8[i]]

tests/base64.test.js

@@ -15,6 +15,7 @@ const pool = raw.map((uint8) => {
   try {
     base64url = buffer.toString('base64url') // unsupported by https://npmjs.com/package/buffer
   } catch {}
+
   if (base64url !== base64urlFallback) throw new Error('Unexpected base64url mismatch with Buffer')
   return { uint8, buffer, hex: buffer.toString('hex'), base64, base64url }
 })
@@ -64,6 +65,7 @@ describe('fromBase64', () => {
           Uint8Array.fromBase64(input, { lastChunkHandling: 'strict', alphabet: 'base64url' })
         )
       }
+
       t.assert.throws(() => fromBase64(input))
       t.assert.throws(() => fromBase64url(input))
       for (const form of ['uint8', 'buffer', 'hex']) {