feat: fromHex never to return pooled TypeArrays/Buffers

Author: ChALkeR

hex.node.js

@@ -22,7 +22,9 @@ export const fromHex = Uint8Array.fromHex
       if (typeof str !== 'string') throw new TypeError(E_STRING)
       if (str.length % 2 !== 0) throw new SyntaxError(E_HEX)
       if (denoBug && /[^\dA-Fa-f]/.test(str)) throw new SyntaxError(E_HEX)
-      const buf = Buffer.from(str, 'hex') // will stop on first non-hex character, so we can just validate length
-      if (buf.length * 2 !== str.length) throw new SyntaxError(E_HEX)
-      return typedView(buf, format)
+      const length = str.length / 2
+      const u8 = new Uint8Array(length)
+      const count = Buffer.from(u8.buffer, u8.byteOffset, u8.byteLength).hexWrite(str, 0, length)
+      if (count !== length) throw new SyntaxError(E_HEX) // will stop on first non-hex character, so we can just validate length
+      return typedView(u8, format)
     }

tests/hex.test.js

@@ -147,4 +147,24 @@ describe('fromHex', () => {
       t.assert.deepStrictEqual(lib.fromHex(hex, 'buffer'), buffer)
     }
   })
+
+  test('fromHex returns non-pooled buffers', (t) => {
+    for (const format of [undefined, 'uint8', 'buffer']) {
+      for (let i = 0; i < 256; i++) {
+        t.assert.strictEqual(fromHex('aa'.repeat(128), format).buffer.byteLength, 128)
+      }
+
+      for (let i = 0; i < 256; i++) {
+        t.assert.strictEqual(fromHex('aa'.repeat(64), format).buffer.byteLength, 64)
+      }
+
+      for (let i = 0; i < 512; i++) {
+        t.assert.strictEqual(fromHex('aa'.repeat(32), format).buffer.byteLength, 32)
+      }
+
+      for (let i = 0; i < 512; i++) {
+        t.assert.strictEqual(fromHex('', format).buffer.byteLength, 0)
+      }
+    }
+  })
 })