feat: add TypeScript types for base58check.js#33
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix issues in base58check.js
Add TypeScript types for base58check.js
Jan 22, 2026
ChALkeR
reviewed
Jan 22, 2026
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
c84154e to
9ac5a57
Compare
ChALkeR
approved these changes
Jan 22, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive TypeScript type definitions for the base58check.js module, which implements base58check encoding (commonly used in Bitcoin addresses). The types follow the established patterns in the codebase and include proper JSDoc documentation.
Changes:
- Added
base58check.d.tswith complete type definitions for all exported functions and interfaces - Updated
package.jsonto include the new type definition file in exports and files array - Enhanced README documentation with detailed descriptions for each base58check function
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base58check.d.ts | Comprehensive TypeScript type definitions for base58check module including async/sync variants and factory function |
| package.json | Added base58check.d.ts to files array and types field to base58check.js export configuration |
| README.md | Added descriptive documentation for all base58check functions explaining their behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Add TypeScript types for base58check.js
toBase58check(async)fromBase58check(async)toBase58checkSync(sync)fromBase58checkSync(sync)makeBase58checkfactory functionSummary
Successfully added comprehensive TypeScript type definitions for
base58check.jsfollowing the existing patterns in the codebase. All tests pass, code review complete, and no security issues detected. Removed unrelated .gitignore change as requested.Original prompt
base58check.js#27💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.