improving example code and adding getter on isFinished

Author: Ashish Aggarwal

examples/index.js

@@ -19,6 +19,8 @@
 
 /// first do `npm install haystack-client` and replace '../dist/index' with 'haystack-client'
 const initTracer = require('../dist/index').initTracer;
+const SpanContext = require('../dist/index').SpanContext;
+
 const opentracing = require('opentracing');
 const MyLogger = require('./logger');
 
@@ -59,11 +61,10 @@ const tracer = initTracer(config);
 
 const serverSpan = tracer
     .startSpan('dummy-operation', {
-        callerSpanContext: {
-            _traceId: '1848fadd-fa16-4b3e-8ad1-6d73339bbee7',
-            _spanId: '7a7cc5bf-796e-4527-9b42-13ae5766c6fd',
-            _parentSpanId: 'e96de653-ad6e-4ad5-b437-e81fd9d2d61d'
-        }
+        callerSpanContext: new SpanContext(
+            '1848fadd-fa16-4b3e-8ad1-6d73339bbee7',
+            '7a7cc5bf-796e-4527-9b42-13ae5766c6fd',
+            'e96de653-ad6e-4ad5-b437-e81fd9d2d61d')
     })
     .setTag(opentracing.Tags.SPAN_KIND, 'server')
     .setTag(opentracing.Tags.HTTP_METHOD, 'GET');

src/span.ts

@@ -83,6 +83,9 @@ export default class Span {
         return this;
     }
 
+    isFinished(): boolean {
+        return this._isFinished;
+    }
     addTags(keyValues: any): Span {
         for (const k in keyValues) {
             if (keyValues.hasOwnProperty(k)) {

src/tracer.ts

@@ -94,7 +94,7 @@ export default class Tracer {
     private _createSpanContext(parent: SpanContext, callerContext: SpanContext): SpanContext {
         if (!parent || !parent.isValid) {
             if (callerContext) {
-                return new SpanContext(callerContext._traceId, callerContext._spanId, callerContext._parentSpanId, callerContext._baggage);
+                return new SpanContext(callerContext.traceId(), callerContext.spanId(), callerContext.parentSpanId(), callerContext.baggage());
             } else {
                 const parentBaggage = parent && parent.baggage();
                 return new SpanContext(Utils.randomUUID(), Utils.randomUUID(), parentBaggage);