Fetching trace details from cassandra in one go

Author: krastogi

reader/src/main/scala/com/expedia/www/haystack/trace/reader/stores/CassandraEsTraceStore.scala

@@ -21,7 +21,7 @@ import com.expedia.www.haystack.trace.commons.clients.cassandra.{CassandraCluste
 import com.expedia.www.haystack.trace.commons.clients.es.document.TraceIndexDoc
 import com.expedia.www.haystack.trace.commons.config.entities.{CassandraConfiguration, WhitelistIndexFieldConfiguration}
 import com.expedia.www.haystack.trace.reader.config.entities.{ElasticSearchConfiguration, ServiceMetadataReadConfiguration}
-import com.expedia.www.haystack.trace.reader.metrics.{AppMetricNames, MetricsSupport}
+import com.expedia.www.haystack.trace.reader.metrics.MetricsSupport
 import com.expedia.www.haystack.trace.reader.stores.readers.ServiceMetadataReader
 import com.expedia.www.haystack.trace.reader.stores.readers.cassandra.CassandraTraceReader
 import com.expedia.www.haystack.trace.reader.stores.readers.es.ElasticSearchReader
@@ -32,7 +32,6 @@ import org.slf4j.LoggerFactory
 
 import scala.collection.JavaConverters._
 import scala.concurrent.{ExecutionContextExecutor, Future}
-import scala.util.{Failure, Success, Try}
 
 class CassandraEsTraceStore(cassandraConfig: CassandraConfiguration,
                             serviceMetadataConfig: ServiceMetadataReadConfiguration,
@@ -82,7 +81,7 @@ class CassandraEsTraceStore(cassandraConfig: CassandraConfiguration,
         .asScala
         .map(source => extractTraceIdFromSource(source))
         .filter(!_.isEmpty)
-        .toSet[String]  // de-dup traceIds
+        .toSet[String] // de-dup traceIds
         .toList
 
       cassandraReader.readRawTraces(traceIds)
@@ -132,11 +131,6 @@ class CassandraEsTraceStore(cassandraConfig: CassandraConfiguration,
     cassandraReader.readRawTraces(request.getTraceIdList.asScala.toList)
   }
 
-  // convert all Futures to Try to make sure they all complete
-  private def liftToTry[T](futures: Seq[Future[T]]): Seq[Future[Try[T]]] = futures.map { f =>
-    f.map(Try(_)).recover { case t: Throwable => Failure(t) }
-  }
-
   override def close(): Unit = {
     cassandraReader.close()
     esReader.close()